Issue 10879058: Experiment to make net_error_list more greppable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10879058: Experiment to make net_error_list more greppable

Created:
8 years, 4 months ago by joth

Modified:
7 years, 7 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, eroman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Experiment to make net_error_list more greppable Explicitly putting the ERR_ prefix on each constant means I can find the values with git grep BUG=

Patch Set 1 #

Patch Set 2 : paste error #

Patch Set 3 : " #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -168 lines)			Patch
M	chrome/browser/ui/webui/net_internals/net_internals_ui.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/download/base_file.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/base/net_error_list.h	View		10 chunks	+162 lines, -162 lines	0 comments	Download
M	net/base/net_errors.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/net_errors.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download