Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1087883005: Remove product specific strings from generated_resources - part 2 (Closed)

Created:
5 years, 8 months ago by gburanov
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-options_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove product specific strings from generated_resources - part 2 Please take a look at first part of this review and also at this conversation https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/xiuyMB5AiNY BUG= Committed: https://crrev.com/1b499b301a82b9c89de21f4b5746e285148b98cf Cr-Commit-Position: refs/heads/master@{#325381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M chrome/app/chromium_strings.grd View 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/renderer_context_menu/spelling_bubble_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/reset_profile_settings_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
gburanov
On 2015/04/15 16:02:10, gburanov wrote: > mailto:gburanov@gmail.com changed reviewers: > + mailto:dbeam@chromium.org Hi the main ...
5 years, 8 months ago (2015-04-15 16:02:51 UTC) #5
gburanov
Hi the main part of this review is for Peter Castling The changes in cc ...
5 years, 8 months ago (2015-04-15 16:03:07 UTC) #6
Peter Kasting
LGTM (But my last name isn't Castling...)
5 years, 8 months ago (2015-04-15 22:02:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087883005/1
5 years, 8 months ago (2015-04-15 22:19:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56670)
5 years, 8 months ago (2015-04-15 22:30:55 UTC) #11
Avi (use Gerrit)
lgtm
5 years, 8 months ago (2015-04-16 02:35:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087883005/1
5 years, 8 months ago (2015-04-16 02:36:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 02:39:32 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 02:40:23 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b499b301a82b9c89de21f4b5746e285148b98cf
Cr-Commit-Position: refs/heads/master@{#325381}

Powered by Google App Engine
This is Rietveld 408576698