chrome/browser/download/download_commands.cc - Issue 1087843004: [Download Notification] Refine retry logic when interrupted or cancelled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_commands.cc

Issue 1087843004: [Download Notification] Refine retry logic when interrupted or cancelled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change retry button behaviour as discussed in mail Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_commands.h ('k') | chrome/browser/download/notification/download_notification_item.h » ('j') | chrome/browser/download/notification/download_notification_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_commands.cc

diff --git a/chrome/browser/download/download_commands.cc b/chrome/browser/download/download_commands.cc

index d571907609d85bbe39e03578f2b094781e295a14..56133f053e47d546d6153cb195c0e3be1491db0e 100644

--- a/chrome/browser/download/download_commands.cc

+++ b/chrome/browser/download/download_commands.cc

@@ -214,14 +214,8 @@ void DownloadCommands::ExecuteCommand(Command command) {

download_item_->Pause();

break;

case RESUME:

- download_item_->Resume();

- break;

case RETRY:

- if (download_item_->CanResume()) {

- download_item_->Resume();

- } else {

- // TODO(yoshiki): Implement retry logic.

- }

+ download_item_->Resume();

break;

}