Issue 108783007: Reland r18383: More API cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108783007: Reland r18383: More API cleanup. (Closed)

Created:
7 years ago by Sven Panne

Modified:
6 years, 11 months ago

Reviewers:
dcarney

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland r18383: More API cleanup. * Removed String::Empty, Number::New, Integer::New, Integer::NewFromUnsigned, FunctionTemplate::New and Object::New without Isolate* parameter. * Removed Integer::New and Integer::NewUnsigned with weird argument order. Chrome CLs matching this change have been landed. TBR=dcarney@chromium.org LOG=y BUG=324225 Committed: https://code.google.com/p/v8/source/detail?r=18449

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+700 lines, -637 lines)			Patch
M	include/v8.h	View	7 chunks	+3 lines, -18 lines	0 comments	Download
M	src/api.cc	View	11 chunks	+11 lines, -62 lines	0 comments	Download
M	src/d8-posix.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/extensions/statistics-extension.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/cctest.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/profiler-extension.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	test/cctest/test-accessors.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View	160 chunks	+433 lines, -371 lines	0 comments	Download
M	test/cctest/test-assembler-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-compiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	12 chunks	+34 lines, -14 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	38 chunks	+79 lines, -58 lines	0 comments	Download
M	test/cctest/test-declarative-accessors.cc	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	test/cctest/test-decls.cc	View	20 chunks	+46 lines, -36 lines	0 comments	Download
M	test/cctest/test-global-handles.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-global-object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	5 chunks	+13 lines, -8 lines	0 comments	Download
M	test/cctest/test-object-observe.cc	View	8 chunks	+35 lines, -30 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	test/cctest/test-thread-termination.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 11 months ago (2014-01-03 11:57:06 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r18449 (presubmit successful).

Expand Messages | Collapse Messages