Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 108783005: Use unsigned integer arithmetic in Zone::NewExpand. (Closed)

Created:
7 years ago by Dmitry Lomov (no reviews)
Modified:
6 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Use unsigned integer arithmetic in Zone::NewExpand. BUG=328202 R=jkummerow@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=18564

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M src/zone.cc View 2 chunks +19 lines, -10 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
PTAL. In some other CL, we might want to switch the entire Zone to size_t
7 years ago (2013-12-16 12:51:30 UTC) #1
Jakob Kummerow
There's definitely a whole lot more that we should clean up long-term, but this LGTM ...
7 years ago (2013-12-16 15:30:34 UTC) #2
Dmitry Lomov (no reviews)
On 2013/12/16 15:30:34, Jakob wrote: > There's definitely a whole lot more that we should ...
7 years ago (2013-12-17 10:27:28 UTC) #3
Dmitry Lomov (no reviews)
6 years, 11 months ago (2014-01-13 13:00:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698