Sync typed urls with typed_cont() == 0

chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/number_formatting.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/sessions/session_service.h"
 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
@@ skipping 359 matching lines @@
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
 
   // Both clients should have this URL as typed and have two visits synced up.
   ASSERT_TRUE(CheckClientsEqual());
   urls = GetTypedUrlsFromClient(0);
   ASSERT_EQ(1U, urls.size());
   ASSERT_EQ(new_url, urls[0].url());
   ASSERT_EQ(2, GetVisitCountForFirstURL(0));
 }
 
+IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest, SyncTypedRedirects) {

[Nicolas Zea, 2015/04/20 19:46:03]

nit: add a comment describing the purpose of the test?

+  const base::string16 kHistoryUrl(ASCIIToUTF16("http://typed.google.com/"));
+  const base::string16 kRedirectedHistoryUrl(
+      ASCIIToUTF16("http://www.typed.google.com/"));
+  ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
+
+  // Simulate a typed address that gets redirected by the server to a different
+  // address.
+  GURL initial_url(kHistoryUrl);
+  const ui::PageTransition initial_transition = ui::PageTransitionFromInt(
+      ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_CHAIN_START);
+  AddUrlToHistoryWithTransition(0, initial_url, initial_transition,
+                                history::SOURCE_BROWSED);
+
+  GURL redirected_url(kRedirectedHistoryUrl);
+  const ui::PageTransition redirected_transition = ui::PageTransitionFromInt(
+      ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_CHAIN_END |
+      ui::PAGE_TRANSITION_SERVER_REDIRECT);
+  // This address will have a typed_count == 0 because it's a redirection.
+  // It should still be synced.
+  AddUrlToHistoryWithTransition(0, redirected_url, redirected_transition,
+                                history::SOURCE_BROWSED);
+
+  // Both clients should have both URLs.
+  ASSERT_TRUE(AwaitCheckAllProfilesHaveSameURLsAsVerifier());
+
+  history::VisitVector visits =
+      typed_urls_helper::GetVisitsForURLFromClient(0, initial_url);
+  ASSERT_EQ(1U, visits.size());
+  EXPECT_TRUE(ui::PageTransitionCoreTypeIs(visits[0].transition,
+                                           ui::PAGE_TRANSITION_TYPED));
+  visits = typed_urls_helper::GetVisitsForURLFromClient(0, redirected_url);
+  ASSERT_EQ(1U, visits.size());
+  EXPECT_TRUE(ui::PageTransitionCoreTypeIs(visits[0].transition,
+                                           ui::PAGE_TRANSITION_TYPED));
+
+  visits = typed_urls_helper::GetVisitsForURLFromClient(1, initial_url);
+  ASSERT_EQ(1U, visits.size());
+  EXPECT_TRUE(ui::PageTransitionCoreTypeIs(visits[0].transition,
+                                           ui::PAGE_TRANSITION_TYPED));
+  visits = typed_urls_helper::GetVisitsForURLFromClient(1, redirected_url);
+  ASSERT_EQ(1U, visits.size());
+  EXPECT_TRUE(ui::PageTransitionCoreTypeIs(visits[0].transition,
+                                           ui::PAGE_TRANSITION_TYPED));
+}
+
 IN_PROC_BROWSER_TEST_F(TwoClientTypedUrlsSyncTest,
                        SkipImportedVisits) {
 
   GURL imported_url("http://imported_url.com");
   GURL browsed_url("http://browsed_url.com");
   GURL browsed_and_imported_url("http://browsed_and_imported_url.com");
   ASSERT_TRUE(SetupClients());
 
   // Create 3 items in our first client - 1 imported, one browsed, one with
   // both imported and browsed entries.
@@ skipping 50 matching lines @@
   // - this should not cause a crash.
   AddUrlToHistory(0, bookmark_url);
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
 
   ASSERT_TRUE(AwaitCheckAllProfilesHaveSameURLsAsVerifier());
   history::URLRows urls = GetTypedUrlsFromClient(0);
   ASSERT_EQ(1U, urls.size());
   ASSERT_EQ(bookmark_url, urls[0].url());
   ASSERT_EQ(1, GetVisitCountForFirstURL(0));
 }