Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1087733002: Revert "Add option to export tracing events to ETW." (Closed)

Created:
5 years, 8 months ago by pdr.
Modified:
5 years, 8 months ago
Reviewers:
Nico, Georges Khalil
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, nasko+codewatch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add option to export tracing events to ETW." This reverts commit 1cc86c4f686869f32dfede093a07828c73563892 due to a compile failures on windows. For more information, see crbug.com/476806. TBR=thakis BUG=476806 Committed: https://crrev.com/dc37b8898c1bfa11ed842cdcb8452412865231c4 Cr-Commit-Position: refs/heads/master@{#325002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -530 lines) Patch
M base/trace_event/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D base/trace_event/etw_manifest/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D base/trace_event/etw_manifest/BUILD/message_compiler.py View 1 chunk +0 lines, -16 lines 0 comments Download
D base/trace_event/etw_manifest/chrome_events_win.man View 1 chunk +0 lines, -84 lines 0 comments Download
D base/trace_event/etw_manifest/etw_manifest.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
M base/trace_event/trace_event.h View 1 chunk +3 lines, -4 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D base/trace_event/trace_event_etw_export_win.h View 1 chunk +0 lines, -66 lines 0 comments Download
D base/trace_event/trace_event_etw_export_win.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pdr.
Could not use the revert button so I created this revert manually. CQ for safety.
5 years, 8 months ago (2015-04-14 03:49:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087733002/1
5 years, 8 months ago (2015-04-14 03:50:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 05:08:15 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 05:09:02 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc37b8898c1bfa11ed842cdcb8452412865231c4
Cr-Commit-Position: refs/heads/master@{#325002}

Powered by Google App Engine
This is Rietveld 408576698