Index: src/lazy/SkDiscardablePixelRef.cpp |
diff --git a/src/lazy/SkDiscardablePixelRef.cpp b/src/lazy/SkDiscardablePixelRef.cpp |
index 6a9507c8c76a713bba3c7a85388e3f8e4c78d702..eb35d0fcc4d5cf4c3cc9eed26a0415183afea76b 100644 |
--- a/src/lazy/SkDiscardablePixelRef.cpp |
+++ b/src/lazy/SkDiscardablePixelRef.cpp |
@@ -11,17 +11,15 @@ |
SkDiscardablePixelRef::SkDiscardablePixelRef(SkImageGenerator* generator, |
const SkImageInfo& info, |
- size_t size, |
size_t rowBytes, |
SkDiscardableMemory::Factory* fact) |
- : fGenerator(generator) |
+ : INHERITED(info) |
+ , fGenerator(generator) |
, fDMFactory(fact) |
- , fInfo(info) |
- , fSize(size) |
, fRowBytes(rowBytes) |
- , fDiscardableMemory(NULL) { |
+ , fDiscardableMemory(NULL) |
+{ |
SkASSERT(fGenerator != NULL); |
- SkASSERT(fSize > 0); |
SkASSERT(fRowBytes > 0); |
// The SkImageGenerator contract requires fGenerator to always |
// decode the same image on each call to getPixels(). |
@@ -35,28 +33,39 @@ SkDiscardablePixelRef::~SkDiscardablePixelRef() { |
SkDELETE(fGenerator); |
} |
-void* SkDiscardablePixelRef::onLockPixels(SkColorTable**) { |
+bool SkDiscardablePixelRef::onNewLockPixels(LockRec* rec) { |
if (fDiscardableMemory != NULL) { |
if (fDiscardableMemory->lock()) { |
- return fDiscardableMemory->data(); |
+ rec->fPixels = fDiscardableMemory->data(); |
+ rec->fColorTable = NULL; |
+ rec->fRowBytes = fRowBytes; |
+ return true; |
} |
SkDELETE(fDiscardableMemory); |
fDiscardableMemory = NULL; |
} |
+ |
+ const size_t size = this->info().getSafeSize(fRowBytes); |
if (fDMFactory != NULL) { |
- fDiscardableMemory = fDMFactory->create(fSize); |
+ fDiscardableMemory = fDMFactory->create(size); |
} else { |
- fDiscardableMemory = SkDiscardableMemory::Create(fSize); |
+ fDiscardableMemory = SkDiscardableMemory::Create(size); |
} |
if (NULL == fDiscardableMemory) { |
- return NULL; // Memory allocation failed. |
+ return false; // Memory allocation failed. |
} |
+ |
void* pixels = fDiscardableMemory->data(); |
- if (!fGenerator->getPixels(fInfo, pixels, fRowBytes)) { |
- return NULL; // TODO(halcanary) Find out correct thing to do. |
+ if (!fGenerator->getPixels(this->info(), pixels, fRowBytes)) { |
+ return false; // TODO(halcanary) Find out correct thing to do. |
} |
- return pixels; |
+ |
+ rec->fPixels = pixels; |
+ rec->fColorTable = NULL; |
+ rec->fRowBytes = fRowBytes; |
+ return true; |
} |
+ |
void SkDiscardablePixelRef::onUnlockPixels() { |
if (fDiscardableMemory != NULL) { |
fDiscardableMemory->unlock(); |
@@ -81,7 +90,6 @@ bool SkInstallDiscardablePixelRef(SkImageGenerator* generator, |
} |
SkAutoTUnref<SkDiscardablePixelRef> ref(SkNEW_ARGS(SkDiscardablePixelRef, |
(generator, info, |
- dst->getSize(), |
dst->rowBytes(), |
factory))); |
dst->setPixelRef(ref); |