Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6386)

Unified Diff: chrome/browser/extensions/settings_api_bubble_controller.h

Issue 1087713002: [Reland] [Extensions] Make extension message bubble factory platform-abstract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finnur's Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings_api_bubble_controller.h
diff --git a/chrome/browser/extensions/settings_api_bubble_controller.h b/chrome/browser/extensions/settings_api_bubble_controller.h
index df64077981f85a6556fec15883339f0df75f8c34..42095330dc4e3330ddc589bb8ad1bf0899a29302 100644
--- a/chrome/browser/extensions/settings_api_bubble_controller.h
+++ b/chrome/browser/extensions/settings_api_bubble_controller.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_EXTENSIONS_SETTINGS_API_BUBBLE_CONTROLLER_H_
#include <string>
+
#include "chrome/browser/extensions/extension_message_bubble_controller.h"
#include "chrome/common/extensions/manifest_handlers/settings_overrides_handler.h"
@@ -18,9 +19,9 @@ class SettingsApiBubbleController : public ExtensionMessageBubbleController {
SettingsApiBubbleController(Profile* profile, SettingsApiOverrideType type);
~SettingsApiBubbleController() override;
- // Whether the controller knows that we should show the bubble for extension
- // with |extension_id|. Returns true if so.
- bool ShouldShow(const std::string& extension_id);
+ // Returns true if we should show the bubble for the extension actively
+ // overriding the setting of |type_|.
+ bool ShouldShow();
// ExtensionMessageBubbleController:
bool CloseOnDeactivate() override;

Powered by Google App Engine
This is Rietveld 408576698