Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: chrome/browser/extensions/extension_action_test_util.cc

Issue 1087713002: [Reland] [Extensions] Make extension message bubble factory platform-abstract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finnur's Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_test_util.cc
diff --git a/chrome/browser/extensions/extension_action_test_util.cc b/chrome/browser/extensions/extension_action_test_util.cc
index cab838e1628a9bdce9f12f209b40944476103b36..da6756e2a5bf426b3a8ce48856c8499668dba5b2 100644
--- a/chrome/browser/extensions/extension_action_test_util.cc
+++ b/chrome/browser/extensions/extension_action_test_util.cc
@@ -116,6 +116,13 @@ size_t GetTotalPageActionCount(content::WebContents* web_contents) {
scoped_refptr<const Extension> CreateActionExtension(const std::string& name,
ActionType action_type) {
+ return CreateActionExtension(name, action_type, Manifest::INTERNAL);
+}
+
+scoped_refptr<const Extension> CreateActionExtension(
+ const std::string& name,
+ ActionType action_type,
+ Manifest::Location location) {
DictionaryBuilder manifest;
manifest.Set("name", name)
.Set("description", "An extension")
@@ -139,6 +146,7 @@ scoped_refptr<const Extension> CreateActionExtension(const std::string& name,
return ExtensionBuilder().SetManifest(manifest.Pass()).
SetID(crx_file::id_util::GenerateId(name)).
+ SetLocation(location).
Build();
}
« no previous file with comments | « chrome/browser/extensions/extension_action_test_util.h ('k') | chrome/browser/extensions/extension_message_bubble.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698