Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 1087653005: ios buildbot scripts (Closed)

Created:
5 years, 8 months ago by stephana-chromium
Modified:
5 years, 8 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Landing directly for testing the ios buildbot code. BUG=skia: TBR=borenet Committed: https://skia.googlesource.com/skia/+/cdec56e72b2dbb3fd15b77ed7ec949322ae731b8

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Added copyright notices #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -1 line) Patch
A platform_tools/ios/bin/ios_mkdir View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_mount.sh View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_ninja View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_path_exists View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_pull.sh View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_pull_if_needed View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_push_file View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_push_if_needed View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_rmdir View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_run_skia View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A platform_tools/ios/bin/ios_setup.sh View 1 2 3 1 chunk +179 lines, -0 lines 1 comment Download
A platform_tools/ios/bin/ios_umount.sh View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M tools/iOSShell.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087653005/20001
5 years, 8 months ago (2015-04-21 13:36:32 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 8 months ago (2015-04-21 13:36:32 UTC) #4
commit-bot: I haz the power
Presubmit check for 1087653005-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-21 13:36:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087653005/40001
5 years, 8 months ago (2015-04-21 13:46:34 UTC) #8
borenet
https://codereview.chromium.org/1087653005/diff/20001/platform_tools/ios/bin/ios_ninja File platform_tools/ios/bin/ios_ninja (right): https://codereview.chromium.org/1087653005/diff/20001/platform_tools/ios/bin/ios_ninja#newcode10 platform_tools/ios/bin/ios_ninja:10: cd ${SKIA_SRC_DIR} why not: pushd ${SKIA_SRC_DIR} ... popd ? ...
5 years, 8 months ago (2015-04-21 13:50:13 UTC) #9
stephana-chromium
I fixed the issues I pointed out. This is still work in progress. I want ...
5 years, 8 months ago (2015-04-21 15:06:53 UTC) #10
borenet
LGTM. We can do a "real" final review once things are settled. https://codereview.chromium.org/1087653005/diff/60001/platform_tools/ios/bin/ios_setup.sh File platform_tools/ios/bin/ios_setup.sh ...
5 years, 8 months ago (2015-04-21 15:09:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087653005/60001
5 years, 8 months ago (2015-04-21 15:20:06 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 15:32:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/cdec56e72b2dbb3fd15b77ed7ec949322ae731b8

Powered by Google App Engine
This is Rietveld 408576698