Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: Source/core/svg/SVGUseElement.cpp

Issue 1087653004: [svg] Update the <use> shadowtree if a referenced element is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/custom/use-remove-referenced-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGUseElement.cpp
diff --git a/Source/core/svg/SVGUseElement.cpp b/Source/core/svg/SVGUseElement.cpp
index 3ff826babec787ae574c67827c586484f61a4e86..90fcdc7690944fa5d366cb8294a0fa71161b5770 100644
--- a/Source/core/svg/SVGUseElement.cpp
+++ b/Source/core/svg/SVGUseElement.cpp
@@ -391,6 +391,10 @@ void SVGUseElement::buildShadowAndInstanceTree(SVGElement* target)
return;
}
+ // Add a reference such that if the target is removed we tear down the
+ // corresponding shadowtree.
+ addReferenceTo(target);
pdr. 2015/04/17 04:57:25 It's been a while since I've been in SVGUseElement
+
if (instanceTreeIsLoading(m_targetElementInstance.get()))
return;
« no previous file with comments | « LayoutTests/svg/custom/use-remove-referenced-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698