Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ppapi/api/private/ppp_content_decryptor_private.idl

Issue 10876014: Hook up CDM calls in CdmWrapper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/private/ppp_content_decryptor_private.idl
diff --git a/ppapi/api/private/ppp_content_decryptor_private.idl b/ppapi/api/private/ppp_content_decryptor_private.idl
index 81d353fde6d15994e0833f871f412618e87db62e..a8add7addd75fd8d3628b9049d1575de6983bf06 100644
--- a/ppapi/api/private/ppp_content_decryptor_private.idl
+++ b/ppapi/api/private/ppp_content_decryptor_private.idl
@@ -6,7 +6,7 @@
/**
* This file defines the <code>PPP_ContentDecryptor_Private</code>
* interface. Note: This is a special interface, only to be used for Content
- * Decryption Modules, not normal plugins.
+ * Decryption Modules (CDM), not normal plugins.
Tom Finegan 2012/08/22 16:54:31 The acronym definition was moved down to the block
ddorwin 2012/08/22 18:25:54 Tom removed this because of the plural - singular
xhwang 2012/08/24 22:01:59 I didn't notice the one on line 19. No need to add
*/
label Chrome {
M23 = 0.1
@@ -36,6 +36,11 @@ interface PPP_ContentDecryptor_Private {
* @param[in] init_data A <code>PP_Var</code> of type
* <code>PP_VARTYPE_ARRAYBUFFER</code> containing container specific
* initialization data.
+ *
+ * @return <code>PP_TRUE</code> if this call can be forwarded to the CDM
ddorwin 2012/08/22 18:25:54 s/can be/was/
xhwang 2012/08/24 22:01:59 Done.
+ * successfully. <code>PP_TRUE</code> otherwise. Once the call reaches the
Tom Finegan 2012/08/22 16:54:31 I think you meant PP_FALSE here. :) Also, sentenc
ddorwin 2012/08/22 18:25:54 PP_FALSE
xhwang 2012/08/24 22:01:59 Done.
+ * CDM, the call result/stuatus can always be reported asynchronously through
Tom Finegan 2012/08/22 16:54:31 s/stuatus/status/ s/can always be/is/ Ditto for r
ddorwin 2012/08/22 18:25:54 s/can always be/should be/ ?
xhwang 2012/08/24 22:01:59 Done.
xhwang 2012/08/24 22:01:59 Done.
+ * the <code>PPB_ContentDecryptor_Private</code> interface.
*/
PP_Bool GenerateKeyRequest(
[in] PP_Instance instance,
@@ -63,6 +68,11 @@ interface PPP_ContentDecryptor_Private {
* @param[in] init_data A <code>PP_Var</code> of type
* <code>PP_VARTYPE_ARRAYBUFFER</code> containing container specific
* initialization data.
+ *
+ * @return <code>PP_TRUE</code> if this call can be forwarded to the CDM
+ * successfully. <code>PP_TRUE</code> otherwise. Once the call reaches the
+ * CDM, the call result/stuatus can always be reported asynchronously through
dmichael (off chromium) 2012/08/23 18:11:29 Here and elsewhere... can we omit asynchronously?
xhwang 2012/08/24 22:01:59 Done.
+ * the <code>PPB_ContentDecryptor_Private</code> interface.
*/
PP_Bool AddKey(
[in] PP_Instance instance,
@@ -75,6 +85,11 @@ interface PPP_ContentDecryptor_Private {
*
* @param[in] session_id A <code>PP_Var</code> of type
* <code>PP_VARTYPE_STRING</code> containing the session ID.
+ *
+ * @return <code>PP_TRUE</code> if this call can be forwarded to the CDM
+ * successfully. <code>PP_TRUE</code> otherwise. Once the call reaches the
+ * CDM, the call result/stuatus can always be reported asynchronously through
+ * the <code>PPB_ContentDecryptor_Private</code> interface.
*/
PP_Bool CancelKeyRequest(
[in] PP_Instance instance,
@@ -93,6 +108,11 @@ interface PPP_ContentDecryptor_Private {
* @param[in] encrypted_block_info A <code>PP_EncryptedBlockInfo</code> that
* contains all auxiliary information needed for decryption of the
* <code>encrypted_block</code>.
+ *
+ * @return <code>PP_TRUE</code> if this call can be forwarded to the CDM
+ * successfully. <code>PP_TRUE</code> otherwise. Once the call reaches the
+ * CDM, the call result/stuatus can always be reported asynchronously through
+ * the <code>PPB_ContentDecryptor_Private</code> interface.
*/
PP_Bool Decrypt(
[in] PP_Instance instance,
@@ -115,6 +135,11 @@ interface PPP_ContentDecryptor_Private {
* @param[in] encrypted_block_info A <code>PP_EncryptedBlockInfo</code> that
* contains all auxiliary information needed for decryption of the
* <code>encrypted_block</code>.
+ *
+ * @return <code>PP_TRUE</code> if this call can be forwarded to the CDM
+ * successfully. <code>PP_TRUE</code> otherwise. Once the call reaches the
+ * CDM, the call result/stuatus can always be reported asynchronously through
+ * the <code>PPB_ContentDecryptor_Private</code> interface.
*/
PP_Bool DecryptAndDecode(
[in] PP_Instance instance,
« no previous file with comments | « no previous file | ppapi/c/private/ppp_content_decryptor_private.h » ('j') | webkit/media/crypto/ppapi/cdm_wrapper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698