Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 1087543004: [strong] Allow mutually recursive classes. (Closed)

Created:
5 years, 8 months ago by marja
Modified:
5 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Allow mutually recursive classes. The previous restrictions were overshooting (didn't allow a class to refer to a later class under any circumstances); after this CL we're undershooting (allow referring to any class from inside a method). Implementing the correct checks (allow referring only if the class declarations are in a consecutive block and if there's no dependency cycle) will be implemented as a follow up. BUG=v8:3956 LOG=N Committed: https://crrev.com/2dc0f2ec01f521a3fea8d8e18dd99c87118b36df Cr-Commit-Position: refs/heads/master@{#27888}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -19 lines) Patch
M src/ast.h View 2 chunks +13 lines, -12 lines 0 comments Download
M src/parser.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M src/scopes.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M src/variables.h View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/strong/declaration-after-use.js View 2 chunks +14 lines, -0 lines 0 comments Download
A test/mjsunit/strong/mutually-recursive-classes.js View 1 2 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
... rossberg@, I was thinking about doing this in pieces since the changes might get ...
5 years, 8 months ago (2015-04-16 13:10:41 UTC) #2
rossberg
lgtm
5 years, 8 months ago (2015-04-16 13:44:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087543004/40001
5 years, 8 months ago (2015-04-16 13:46:12 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-16 14:13:08 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 14:13:14 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2dc0f2ec01f521a3fea8d8e18dd99c87118b36df
Cr-Commit-Position: refs/heads/master@{#27888}

Powered by Google App Engine
This is Rietveld 408576698