Enable FilePathWatcher base unittests on Android.

Enable FilePathWatcher base unittests on Android.

It's used on Android so it should be tested on Android.
Some pieces of tests are disabled until crbug.com/475568 is fixed.

BUG=475570
R=mnissler@chromium.org
TEST=base_unittests

Committed: https://crrev.com/7a4e7804b6761017e6e2f944401ea273bac5887b
Cr-Commit-Position: refs/heads/master@{#324915}

[pauljensen, 2015-04-13 12:17:38]

PTAL.

[Mattias Nissler (ping if slow), 2015-04-13 13:06:07]

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
File base/files/file_path_watcher_unittest.cc (right):

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
base/files/file_path_watcher_unittest.cc:544: // TODO(pauljensen): Re-enable
when crbug.com/475568 is fixed.
It seems that the referenced bug doesn't cover the file attribute problem we're
running into here. Are file attributes generally off bounds on Android, or the
idea to change the test to run against a file system that supports them? Would
be great to clarify the comment to that effect.

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
base/files/file_path_watcher_unittest.cc:564: // TODO(pauljensen): Re-enable
when crbug.com/475568 is fixed.
ditto re scope of the referenced bug and intended fix.

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
base/files/file_path_watcher_unittest.cc:638: // TODO(pauljensen): Re-enable
when crbug.com/475568 is fixed.
ditto

[pauljensen, 2015-04-13 13:27:04]

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
File base/files/file_path_watcher_unittest.cc (right):

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
base/files/file_path_watcher_unittest.cc:544: // TODO(pauljensen): Re-enable
when crbug.com/475568 is fixed.
On 2015/04/13 13:06:07, Mattias Nissler wrote:
> It seems that the referenced bug doesn't cover the file attribute problem
we're
> running into here. Are file attributes generally off bounds on Android, or the
> idea to change the test to run against a file system that supports them? Would
> be great to clarify the comment to that effect.

Done.

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
base/files/file_path_watcher_unittest.cc:564: // TODO(pauljensen): Re-enable
when crbug.com/475568 is fixed.
On 2015/04/13 13:06:07, Mattias Nissler wrote:
> ditto re scope of the referenced bug and intended fix.

Done.

https://codereview.chromium.org/1087503003/diff/1/base/files/file_path_watche...
base/files/file_path_watcher_unittest.cc:638: // TODO(pauljensen): Re-enable
when crbug.com/475568 is fixed.
On 2015/04/13 13:06:07, Mattias Nissler wrote:
> ditto

Done.

[Mattias Nissler (ping if slow), 2015-04-13 14:42:21]

LGTM

[pauljensen, 2015-04-13 14:53:04]

pauljensen@chromium.org changed reviewers:
+ thestig@chromium.org

[pauljensen, 2015-04-13 14:53:04]

+thestig@ for review of base/BUILD.gn and base/base.gyp

[Lei Zhang, 2015-04-13 19:50:58]

lgtm

[pauljensen, 2015-04-13 19:57:09]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2015-04-13 19:57:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087503003/20001

[commit-bot: I haz the power, 2015-04-13 21:28:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-13 21:32:58]

Patchset 2 (id:??) landed as
https://crrev.com/7a4e7804b6761017e6e2f944401ea273bac5887b
Cr-Commit-Position: refs/heads/master@{#324915}