Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1087463003: Fix indirect push (Closed)

Created:
5 years, 8 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix indirect push BUG=chromium:388665 LOG=n Committed: https://crrev.com/434b456b519e62ed814061c87bb424182887170d Cr-Commit-Position: refs/heads/master@{#27795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -22 lines) Patch
M src/hydrogen.cc View 3 chunks +7 lines, -15 lines 0 comments Download
A + test/mjsunit/regress/regress-indirect-push-unchecked.js View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 8 months ago (2015-04-13 15:34:32 UTC) #2
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-13 15:43:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087463003/1
5 years, 8 months ago (2015-04-13 15:43:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 16:25:43 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 16:25:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/434b456b519e62ed814061c87bb424182887170d
Cr-Commit-Position: refs/heads/master@{#27795}

Powered by Google App Engine
This is Rietveld 408576698