Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Issue 108743002: Actually call the NormlizeFilePath function for download platform detection. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Actually call the NormlizeFilePath function for download platform detection. This should make Cygwin work to match "win32". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=239244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M download_from_google_storage.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
7 years ago (2013-12-06 18:27:45 UTC) #1
M-A Ruel
lgtm
7 years ago (2013-12-06 18:28:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/108743002/1
7 years ago (2013-12-06 18:29:06 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-06 18:30:59 UTC) #4
Message was sent while issue was closed.
Change committed as 239244

Powered by Google App Engine
This is Rietveld 408576698