Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1087423003: Revert of Build the Clang plugin on Windows. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build the Clang plugin on Windows. (patchset #7 id:120001 of https://codereview.chromium.org/1072203002/) Reason for revert: Rebase went horribly wrong... Original issue's description: > Build the Clang plugin on Windows. > > This also includes several fixes for the plugin logic on Windows: > - The banned directory check normalizes path separators. > - The banned directory check now returns true for files that are > considered system headers. > - Diagnostics from the plugin are always reported as warnings. > > BUG=467287 > R=thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20 > > Committed: https://chromium.googlesource.com/chromium/src/+/5b5d1269ade9eeb50875b20570ef3e0d8c5d95fb TBR=hans@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467287 Committed: https://crrev.com/76a1992ac341353aabea114913e9805e2f92eaa9 Cr-Commit-Position: refs/heads/master@{#325371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Build the Clang plugin on Windows.
5 years, 8 months ago (2015-04-16 01:38:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087423003/1
5 years, 8 months ago (2015-04-16 01:39:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 01:40:05 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 01:41:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76a1992ac341353aabea114913e9805e2f92eaa9
Cr-Commit-Position: refs/heads/master@{#325371}

Powered by Google App Engine
This is Rietveld 408576698