runtime/observatory/lib/src/app/page.dart - Issue 1087393002: Add page view analytics to Observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 1087393002: Add page view analytics to Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/app/page.dart

diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart

index e79f3dc40ac6dd97c3b4d34dbc60446f5aa105e7..858e75f275880901a945463b20c4fc787cafbc51 100644

--- a/runtime/observatory/lib/src/app/page.dart

+++ b/runtime/observatory/lib/src/app/page.dart

@@ -27,9 +27,9 @@ abstract class Page extends Observable {

}

/// Called when the page should update its state based on [uri].

- /// NOTE: Only called when the page is installed.

void visit(Uri uri, Map argsMap) {

args = toObservable(argsMap);

+ Analytics.reportPageView(uri);

_visit(uri);

}