Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1087363002: Add missing dependency to chrome_java_test_support GN target. (Closed)

Created:
5 years, 8 months ago by newt (away)
Modified:
5 years, 8 months ago
Reviewers:
cjhopman, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency to chrome_java_test_support GN target. TBR=dfalcantara@chromium.org Committed: https://crrev.com/444d21a07be9a6da568edb725391429674316c3d Cr-Commit-Position: refs/heads/master@{#325522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/test/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
newt (away)
PTAL
5 years, 8 months ago (2015-04-15 21:59:36 UTC) #2
cjhopman
lgtm
5 years, 8 months ago (2015-04-16 20:31:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087363002/1
5 years, 8 months ago (2015-04-16 21:21:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56959)
5 years, 8 months ago (2015-04-16 21:33:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087363002/1
5 years, 8 months ago (2015-04-16 21:37:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 21:47:16 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 21:49:15 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/444d21a07be9a6da568edb725391429674316c3d
Cr-Commit-Position: refs/heads/master@{#325522}

Powered by Google App Engine
This is Rietveld 408576698