Add an ONC property for setting per-network roam threshold

Add an ONC property for setting per-network roam threshold

This CL maps an  ONC property for setting per-network roam threshold.

BUG=chrome-os-partner:38681
TEST=Expanded test ONC and JSON test sets

Committed: https://crrev.com/f8c7616547bed21a7296d8beb3962068aa301366
Cr-Commit-Position: refs/heads/master@{#325515}

[samueltan, 2015-04-15 21:42:53]

samueltan@chromium.org changed reviewers:
+ pneubeck@chromium.org, stevenjb@chromium.org

[stevenjb, 2015-04-16 17:04:12]

stevenjb@chromium.org changed required reviewers:
+ pneubeck@chromium.org

[stevenjb, 2015-04-16 17:04:13]

This lgtm, but preferably please wait for pneubeck@ also.

[pneubeck (no reviews), 2015-04-16 17:10:52]

apart from the inline comments, lgtm

https://codereview.chromium.org/1087353002/diff/1/components/onc/docs/onc_spe...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/1087353002/diff/1/components/onc/docs/onc_spe...
components/onc/docs/onc_spec.html:734: (in dB) below which wpa_supplicant will
attempt to roam to a new network.
better remove references to concrete implementations (...the network manager...
is usually fine), like wpa_supplicant, or only mention it as an example.

https://codereview.chromium.org/1087353002/diff/1/components/onc/docs/onc_spe...
components/onc/docs/onc_spec.html:735: If this value is not set, the roam
threshold for the current WiFi device
these two sentences about the WiFi device's roam threshold don't make sense to
the reader as there is no such setting (i know that there is in Shill).

probably just remove it and talk a bout a 'default' value.

[samueltan, 2015-04-16 17:41:07]

https://codereview.chromium.org/1087353002/diff/1/components/onc/docs/onc_spe...
File components/onc/docs/onc_spec.html (right):

https://codereview.chromium.org/1087353002/diff/1/components/onc/docs/onc_spe...
components/onc/docs/onc_spec.html:734: (in dB) below which wpa_supplicant will
attempt to roam to a new network.
On 2015/04/16 17:10:51, pneubeck wrote:
> better remove references to concrete implementations (...the network
manager...
> is usually fine), like wpa_supplicant, or only mention it as an example.

Done.

https://codereview.chromium.org/1087353002/diff/1/components/onc/docs/onc_spe...
components/onc/docs/onc_spec.html:735: If this value is not set, the roam
threshold for the current WiFi device
On 2015/04/16 17:10:51, pneubeck wrote:
> these two sentences about the WiFi device's roam threshold don't make sense to
> the reader as there is no such setting (i know that there is in Shill).
> 
> probably just remove it and talk a bout a 'default' value.

Done. The description is now:

The roam threshold for this network, which is the signal-to-noise value (in dB)
below which we will attempt to roam to a new network. If this value is not set,
the default value will be used.

[samueltan, 2015-04-16 17:45:02]

The CQ bit was checked by samueltan@chromium.org

[samueltan, 2015-04-16 17:45:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, pneubeck@chromium.org
Link to the patchset: https://codereview.chromium.org/1087353002/#ps20001
(title: "Revised ONC spec doc")

[commit-bot: I haz the power, 2015-04-16 17:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087353002/20001

[commit-bot: I haz the power, 2015-04-16 21:21:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-16 21:22:27]

Patchset 2 (id:??) landed as
https://crrev.com/f8c7616547bed21a7296d8beb3962068aa301366
Cr-Commit-Position: refs/heads/master@{#325515}