Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1087333004: MD5: Remove unnecessary temporary 'inbuf' variable. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD5: Remove unnecessary temporary 'inbuf' variable. It does not seem necessary to have this variable, just to create another down below called 'buf'. BUG=None TEST=base_unittests --gtest_filter=MD5* R=thestig@chromium.org Committed: https://crrev.com/0dd3462e047faa4dc4a5e5ac1fc5f58ca589a489 Cr-Commit-Position: refs/heads/master@{#325473}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M base/md5.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
tfarina
5 years, 8 months ago (2015-04-16 03:50:21 UTC) #1
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-16 08:22:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087333004/1
5 years, 8 months ago (2015-04-16 08:23:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48732)
5 years, 8 months ago (2015-04-16 11:08:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087333004/1
5 years, 8 months ago (2015-04-16 12:23:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/48795)
5 years, 8 months ago (2015-04-16 14:19:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087333004/1
5 years, 8 months ago (2015-04-16 15:25:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087333004/20001
5 years, 8 months ago (2015-04-16 16:20:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 17:50:54 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:51:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dd3462e047faa4dc4a5e5ac1fc5f58ca589a489
Cr-Commit-Position: refs/heads/master@{#325473}

Powered by Google App Engine
This is Rietveld 408576698