Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1087333002: Define mojo_build_mojo_shell_from_source = true (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
Reviewers:
jam, scottmg
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define mojo_build_mojo_shell_from_source = true Chromium builds its own mojo_shell from forked source. This logic was originally changed incorrectly: https://codereview.chromium.org/1049993002/diff/170001/third_party/mojo/src/mojo/public/mojo.gni That was clobbered in the latest Mojo->Chromium roll: https://codereview.chromium.org/1082343002/diff/40001/third_party/mojo/src/mojo/public/mojo.gni BUG=NONE TEST=mojo_shell binary built from chromium repo. R=jam@chromium.org TBR=scottmg@chromium.org Committed: https://crrev.com/f8d7df392c96b8b7bf5ed95cd31176cebddb3889 Cr-Commit-Position: refs/heads/master@{#325322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/module_args/mojo.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
msw
Hey John, please take a look; thanks!
5 years, 8 months ago (2015-04-15 21:34:52 UTC) #1
msw
+scottmg for OWNERS; landing for green tree, unborked ToT.
5 years, 8 months ago (2015-04-15 21:40:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087333002/1
5 years, 8 months ago (2015-04-15 21:41:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 22:06:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8d7df392c96b8b7bf5ed95cd31176cebddb3889 Cr-Commit-Position: refs/heads/master@{#325322}
5 years, 8 months ago (2015-04-15 22:08:19 UTC) #7
jam
5 years, 8 months ago (2015-04-15 22:45:09 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698