Source/platform/graphics/filters/FEColorMatrix.h - Issue 1087283002: Rework the checks for too-few values in feColorMatrix filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/FEColorMatrix.h

Issue 1087283002: Rework the checks for too-few values in feColorMatrix filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Better tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1.html ('K') | « Source/core/svg/SVGFEColorMatrixElement.cpp ('k') | Source/platform/graphics/filters/FEColorMatrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/FEColorMatrix.h

diff --git a/Source/platform/graphics/filters/FEColorMatrix.h b/Source/platform/graphics/filters/FEColorMatrix.h

index 2ae8be952b30f45579791ed43d2dd2b711c9f34c..469621cf70bbc18c42ad8edb29a42cbc28021b4b 100644

--- a/Source/platform/graphics/filters/FEColorMatrix.h

+++ b/Source/platform/graphics/filters/FEColorMatrix.h

@@ -59,6 +59,9 @@ private:

virtual bool affectsTransparentPixels() override;

ColorMatrixType m_type;

+ // The m_values vector may not contain the right number of values. Always check

+ // before accessing contents.

Vector<float> m_values;

};