LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1.html - Issue 1087283002: Rework the checks for too-few values in feColorMatrix filter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1.html

Issue 1087283002: Rework the checks for too-few values in feColorMatrix filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Better tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 function testDone() {

	6 if (window.testRunner) {

	7 testRunner.dumpAsText();

	8 testRunner.notifyDone();

	9 }

	10 }

	11

	12 function changeValues() {

	13 document.getElementById('color').setAttribute('values', '1');

	14 requestAnimationFrame(testDone);

	15 }

	16

	17 function forcePaint() {

	18 requestAnimationFrame(changeValues);

	19 }

	20

	21 onload = function() {

	22 if (window.testRunner) {

	23 testRunner.waitUntilDone();

	24 }

	25 requestAnimationFrame(forcePaint);
	pdr. 2015/04/16 19:19:16 Does this test really need three requestAnimationF Does this test really need three requestAnimationFrames? I suspect you can change this one to requestAnimationFrame(changeValues); Stephen Chennney 2015/04/16 19:30:32 It's needed. The first one comes before any frame, Show quoted text On 2015/04/16 19:19:16, pdr wrote: > Does this test really need three requestAnimationFrames? I suspect you can > change this one to requestAnimationFrame(changeValues); It's needed. The first one comes before any frame, so the scheduled animation function (forcePaint) is called before the first paint. Then we schedule the next one (changeValue), which happens after the first paint. It sets the values, then requests another frame which leads to the second paint and the crash. We have to schedule something then to happen after that frame (testDone) to finish the test.
	26 }

	27 </script>

	28 </head>

	29 <body>

	30 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="100" height="100" fil ter="url(#MyFilter)" version="1.1">

	31 <defs>

	32 <filter id="MyFilter">

	33 <fecolormatrix id="color" type="matrix"></fecolormatrix>

	34 </filter>

	35 </defs>

	36 </svg>

	37 PASS

	38 </body>

	39 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1-expected.txt » ('j') | no next file with comments »