LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1.html - Issue 1087283002: Rework the checks for too-few values in feColorMatrix filter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/filters/feColorMatrix-setAttribute-crash1.html

Issue 1087283002: Rework the checks for too-few values in feColorMatrix filter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Correct patch Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 function changeValues() {

	6 document.getElementById('color').setAttribute('values', '1');

	7 if (window.testRunner) {

	8 testRunner.notifyDone();

	9 }

	10 }

	11

	12 onload = function() {

	13 if (window.testRunner) {

	14 testRunner.waitUntilDone();

	15 }

	16 setTimeout(changeValues, 100);
	pdr. 2015/04/15 18:34:22 What's this timer waiting on? What's this timer waiting on? fs 2015/04/15 22:07:27 For SVGFEColorMatrixElement::build to be called I Show quoted text On 2015/04/15 18:34:22, pdr wrote: > What's this timer waiting on? For SVGFEColorMatrixElement::build to be called I suspect? Waiting for a paint ought to suffice I think. Stephen Chennney 2015/04/16 18:12:19 Yes, a paint is needed. In fact, 2 paints are need Show quoted text On 2015/04/15 22:07:27, fs wrote: > On 2015/04/15 18:34:22, pdr wrote: > > What's this timer waiting on? > > For SVGFEColorMatrixElement::build to be called I suspect? Waiting for a paint > ought to suffice I think. Yes, a paint is needed. In fact, 2 paints are needed. I've used the appropriate method to make that happen. Stephen Chennney 2015/04/16 18:12:19 Yes. But I found the way to make it happen. Show quoted text On 2015/04/15 22:07:27, fs wrote: > On 2015/04/15 18:34:22, pdr wrote: > > What's this timer waiting on? > > For SVGFEColorMatrixElement::build to be called I suspect? Waiting for a paint > ought to suffice I think. Yes. But I found the way to make it happen.
	17 }

	18 </script>

	19 </head>

	20 <body>

	21 <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="100" height="100" fil ter="url(#MyFilter)" version="1.1">

	22 <defs>

	23 <filter id="MyFilter">

	24 <fecolormatrix id="color" type="matrix"></fecolormatrix>

	25 </filter>

	26 </defs>

	27 </svg>

	28 </body>

	29 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/svg/SVGFEColorMatrixElement.cpp » ('j') | Source/platform/graphics/filters/FEColorMatrix.cpp » ('J')