tools/metrics/histograms/histograms.xml - Issue 1087233002: Report the number of empty usernames without a nonempty pair.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1087233002: Report the number of empty usernames without a nonempty pair. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/password_manager/core/browser/login_database_unittest.cc ('K') | « components/password_manager/core/browser/login_database_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 690a2d7afa474d116aaf3659357c962371538868..69d63cd92b1d0a64f67038e2b54fd71fea4d3630 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -25307,6 +25307,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="PasswordManager.EmptyUsernames.NotPairedWithNonempty">

engedy 2015/04/15 15:29:26 I think the concept of "pairing" is a bit unclear

msramek 2015/04/16 14:34:26 Sure. Naming is always the hardest.

+ <owner>msramek@chromium.org</owner>

+ <owner>vasilii@chromium.org</owner>

+ <summary>

+ Number of password forms with empty username in the Login Database for which

+ there isn't another password form from the same realm with a nonempty

engedy 2015/04/15 15:29:26 nit: s/isn't/is not/

msramek 2015/04/16 14:34:26 Done.

+ username. In other words, number of password forms with empty username which

+ we do not suspect to be reauthentication forms.

+ </summary>

+</histogram>

<histogram name="PasswordManager.EmptyUsernames.OfferedToSave"

enum="PasswordManagerShowEmptyUsername">

<owner>vasilii@chromium.org</owner>