Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: components/password_manager/core/browser/login_database.cc

Issue 1087233002: Report the number of empty usernames without a nonempty pair. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/login_database.h" 5 #include "components/password_manager/core/browser/login_database.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 4); 497 4);
498 498
499 sql::Statement empty_usernames_statement(db_.GetCachedStatement( 499 sql::Statement empty_usernames_statement(db_.GetCachedStatement(
500 SQL_FROM_HERE, "SELECT COUNT(*) FROM logins " 500 SQL_FROM_HERE, "SELECT COUNT(*) FROM logins "
501 "WHERE blacklisted_by_user=0 AND username_value=''")); 501 "WHERE blacklisted_by_user=0 AND username_value=''"));
502 if (empty_usernames_statement.Step()) { 502 if (empty_usernames_statement.Step()) {
503 int empty_forms = empty_usernames_statement.ColumnInt(0); 503 int empty_forms = empty_usernames_statement.ColumnInt(0);
504 UMA_HISTOGRAM_COUNTS_100("PasswordManager.EmptyUsernames.CountInDatabase", 504 UMA_HISTOGRAM_COUNTS_100("PasswordManager.EmptyUsernames.CountInDatabase",
505 empty_forms); 505 empty_forms);
506 } 506 }
507
508 sql::Statement standalone_empty_usernames_statement(db_.GetCachedStatement(
509 SQL_FROM_HERE, "SELECT COUNT(*) FROM logins a "
510 "WHERE a.blacklisted_by_user=0 AND a.username_value='' "
511 "AND NOT EXISTS (SELECT * FROM logins b "
512 "WHERE b.blacklisted_by_user=0 AND b.username_value!='' "
513 "AND a.signon_realm = b.signon_realm)"));
514 if (standalone_empty_usernames_statement.Step()) {
515 int num_entries = standalone_empty_usernames_statement.ColumnInt(0);
516 UMA_HISTOGRAM_COUNTS_100(
517 "PasswordManager.EmptyUsernames.WithoutCorrespondingNonempty",
518 num_entries);
519 }
507 } 520 }
508 521
509 PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) { 522 PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) {
510 PasswordStoreChangeList list; 523 PasswordStoreChangeList list;
511 if (!DoesMatchConstraints(form)) 524 if (!DoesMatchConstraints(form))
512 return list; 525 return list;
513 std::string encrypted_password; 526 std::string encrypted_password;
514 if (EncryptedString(form.password_value, &encrypted_password) != 527 if (EncryptedString(form.password_value, &encrypted_password) !=
515 ENCRYPTION_RESULT_SUCCESS) 528 ENCRYPTION_RESULT_SUCCESS)
516 return list; 529 return list;
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
932 UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering", 945 UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering",
933 psl_domain_match_metric, PSL_DOMAIN_MATCH_COUNT); 946 psl_domain_match_metric, PSL_DOMAIN_MATCH_COUNT);
934 } 947 }
935 948
936 if (!statement->Succeeded()) 949 if (!statement->Succeeded())
937 return false; 950 return false;
938 return true; 951 return true;
939 } 952 }
940 953
941 } // namespace password_manager 954 } // namespace password_manager
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698