Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/hydrogen.cc

Issue 1087213002: VectorICs: recent changes broke cases with --novector-ics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/type-feedback-vector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/hydrogen.h" 5 #include "src/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 6909 matching lines...) Expand 10 before | Expand all | Expand 10 after
6920 HValue* key, 6920 HValue* key,
6921 HValue* value) { 6921 HValue* value) {
6922 if (access_type == LOAD) { 6922 if (access_type == LOAD) {
6923 InlineCacheState initial_state = 6923 InlineCacheState initial_state =
6924 FLAG_vector_ics ? expr->AsProperty()->GetInlineCacheState() 6924 FLAG_vector_ics ? expr->AsProperty()->GetInlineCacheState()
6925 : PREMONOMORPHIC; 6925 : PREMONOMORPHIC;
6926 HLoadKeyedGeneric* result = 6926 HLoadKeyedGeneric* result =
6927 New<HLoadKeyedGeneric>(object, key, initial_state); 6927 New<HLoadKeyedGeneric>(object, key, initial_state);
6928 // HLoadKeyedGeneric with vector ics benefits from being encoded as 6928 // HLoadKeyedGeneric with vector ics benefits from being encoded as
6929 // MEGAMORPHIC because the vector/slot combo becomes unnecessary. 6929 // MEGAMORPHIC because the vector/slot combo becomes unnecessary.
6930 if (initial_state != MEGAMORPHIC) { 6930 if (FLAG_vector_ics && initial_state != MEGAMORPHIC) {
6931 // We need to pass vector information. 6931 // We need to pass vector information.
6932 Handle<TypeFeedbackVector> vector = 6932 Handle<TypeFeedbackVector> vector =
6933 handle(current_feedback_vector(), isolate()); 6933 handle(current_feedback_vector(), isolate());
6934 FeedbackVectorICSlot slot = expr->AsProperty()->PropertyFeedbackSlot(); 6934 FeedbackVectorICSlot slot = expr->AsProperty()->PropertyFeedbackSlot();
6935 result->SetVectorAndSlot(vector, slot); 6935 result->SetVectorAndSlot(vector, slot);
6936 } 6936 }
6937 return result; 6937 return result;
6938 } else { 6938 } else {
6939 return New<HStoreKeyedGeneric>(object, key, value, function_language_mode(), 6939 return New<HStoreKeyedGeneric>(object, key, value, function_language_mode(),
6940 PREMONOMORPHIC); 6940 PREMONOMORPHIC);
(...skipping 6007 matching lines...) Expand 10 before | Expand all | Expand 10 after
12948 if (ShouldProduceTraceOutput()) { 12948 if (ShouldProduceTraceOutput()) {
12949 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 12949 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
12950 } 12950 }
12951 12951
12952 #ifdef DEBUG 12952 #ifdef DEBUG
12953 graph_->Verify(false); // No full verify. 12953 graph_->Verify(false); // No full verify.
12954 #endif 12954 #endif
12955 } 12955 }
12956 12956
12957 } } // namespace v8::internal 12957 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/type-feedback-vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698