Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1087213002: VectorICs: recent changes broke cases with --novector-ics (Closed)

Created:
5 years, 8 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: recent changes broke cases with --novector-ics Ensure that we protect turning off the vector ics flag. BUG= R=yangguo@chromium.org Committed: https://crrev.com/a2481f8dd9faae2b7ced665afd30f8d85a914018 Cr-Commit-Position: refs/heads/master@{#27844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
lgtm
5 years, 8 months ago (2015-04-15 11:38:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087213002/1
5 years, 8 months ago (2015-04-15 11:39:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 12:50:02 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:50:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2481f8dd9faae2b7ced665afd30f8d85a914018
Cr-Commit-Position: refs/heads/master@{#27844}

Powered by Google App Engine
This is Rietveld 408576698