Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1087203004: Store pointers to GrGlyph directly in BitmapTextBlob (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@atdfopt2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Store pointers to GrGlyph directly in BitmapTextBlob. This patch improves performance by avoiding hashmap lookups under normal use BUG=skia: Committed: https://skia.googlesource.com/skia/+/ae32c102e70577bff1432ef4b4b63ca6835012f6

Patch Set 1 #

Patch Set 2 : fix rebase #

Patch Set 3 : tidying- #

Patch Set 4 : more #

Total comments: 1

Patch Set 5 : adding comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -28 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 2 3 4 5 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 12 chunks +43 lines, -15 lines 0 comments Download
M src/gpu/GrBatchFontCache.h View 1 2 3 4 4 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrTextBlobCache.cpp View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-20 13:04:50 UTC) #2
jvanverth1
I assume that this is to improve perf by removing hashmap lookups. If so, you ...
5 years, 8 months ago (2015-04-20 15:51:18 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/1087203004/diff/60001/src/gpu/GrAtlasTextContext.cpp File src/gpu/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1087203004/diff/60001/src/gpu/GrAtlasTextContext.cpp#newcode1543 src/gpu/GrAtlasTextContext.cpp:1543: Probably should have a parallel (but shorter) comment ...
5 years, 8 months ago (2015-04-21 12:32:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087203004/80001
5 years, 8 months ago (2015-04-21 15:52:06 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 16:38:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/ae32c102e70577bff1432ef4b4b63ca6835012f6

Powered by Google App Engine
This is Rietveld 408576698