Reland of crrev.com/1100173002 (Add a WinHeap dump provider to the memory profiler.)

Reland of crrev.com/1100173002 (Add a WinHeap dump provider to the memory profiler.)

Reason of reland: fixed gn files.

Add a WinHeap dump provider to the memory profiler.

TBR=nduca@chromium.org
BUG=466141
Committed: https://crrev.com/61dfbd59a9f6424197a1c1fadde0703d5ca65446
Cr-Commit-Position: refs/heads/master@{#326573}

[Sébastien Marchand, 2015-04-23 14:21:43]

sebmarchand@chromium.org changed reviewers:
+ primiano@chromium.org

[Sébastien Marchand, 2015-04-23 14:21:43]

PTAL.

[Primiano Tucci (use gerrit), 2015-04-23 15:42:54]

LGTM

[Primiano Tucci (use gerrit), 2015-04-23 15:42:58]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2015-04-23 15:43:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1087133005/1

[commit-bot: I haz the power, 2015-04-23 17:58:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-23 17:58:58]

Patchset 1 (id:??) landed as
https://crrev.com/61dfbd59a9f6424197a1c1fadde0703d5ca65446
Cr-Commit-Position: refs/heads/master@{#326573}

[Reid Kleckner, 2015-04-23 18:27:36]

rnk@chromium.org changed reviewers:
+ rnk@chromium.org

[Reid Kleckner, 2015-04-23 18:27:37]

https://codereview.chromium.org/1087133005/diff/1/base/trace_event/winheap_du...
File base/trace_event/winheap_dump_provider_win.cc (right):

https://codereview.chromium.org/1087133005/diff/1/base/trace_event/winheap_du...
base/trace_event/winheap_dump_provider_win.cc:42:
DCHECK_NE(reinterpret_cast<ProcessMemoryDump*>(nullptr), pmd);
Clang rejects this line with this error:
..\..\base\trace_event\winheap_dump_provider_win.cc(42,13) :  error:
reinterpret_cast from 'nullptr_t' to 'base::trace_event::ProcessMemoryDump *' is
not allowed

I don't know why you can't do this reinterpret_cast, but static_cast works fine,
so do you mind going with that?

[Justin Donnelly, 2015-04-23 20:36:00]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1101173002/ by jdonnelly@chromium.org.

The reason for reverting is: WinHeapDumpProviderTest.GetHeapInformation is
failing on XP Tests (1) bot.

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build....

[Sébastien Marchand, 2015-04-24 09:03:50]

This is relanding in https://codereview.chromium.org/1083003003/ (I've address
Reid's comment too)

https://codereview.chromium.org/1087133005/diff/1/base/trace_event/winheap_du...
File base/trace_event/winheap_dump_provider_win.cc (right):

https://codereview.chromium.org/1087133005/diff/1/base/trace_event/winheap_du...
base/trace_event/winheap_dump_provider_win.cc:42:
DCHECK_NE(reinterpret_cast<ProcessMemoryDump*>(nullptr), pmd);
On 2015/04/23 18:27:37, Reid Kleckner wrote:
> Clang rejects this line with this error:
> ..\..\base\trace_event\winheap_dump_provider_win.cc(42,13) :  error:
> reinterpret_cast from 'nullptr_t' to 'base::trace_event::ProcessMemoryDump *'
is
> not allowed
> 
> I don't know why you can't do this reinterpret_cast, but static_cast works
fine,
> so do you mind going with that?

Done.