extensions/browser/guest_view/web_view/web_view_find_helper.cc - Issue 1087123002: Towards Decoupling GuestView from Extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_find_helper.cc

Issue 1087123002: Towards Decoupling GuestView from Extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lazyboy@'s comments. Removed unnecessary includes. Simplified GuestViewEvent. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_find_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_find_helper.cc b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

index 8539b257b7baa16330ac1fe721c0878cfc33a311..8028e9133e09a4dcdd5dc510fdb8ea46c6bb0da3 100644

--- a/extensions/browser/guest_view/web_view/web_view_find_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

@@ -7,6 +7,7 @@

#include <utility>

#include "extensions/browser/api/guest_view/web_view/web_view_internal_api.h"

+#include "extensions/browser/guest_view/guest_view_event.h"

#include "extensions/browser/guest_view/web_view/web_view_constants.h"

namespace extensions {

@@ -38,7 +39,7 @@ void WebViewFindHelper::DispatchFindUpdateEvent(bool canceled,

args->SetBoolean(webview::kFindFinalUpdate, final_update);

DCHECK(webview_guest_);

webview_guest_->DispatchEventToView(

- new GuestViewBase::Event(webview::kEventFindReply, args.Pass()));

+ new GuestViewEvent(webview::kEventFindReply, args.Pass()));

}

void WebViewFindHelper::EndFindSession(int session_request_id, bool canceled) {