extensions/browser/guest_view/guest_view_manager.h - Issue 1087123002: Towards Decoupling GuestView from Extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_manager.h

Issue 1087123002: Towards Decoupling GuestView from Extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lazyboy@'s comments. Removed unnecessary includes. Simplified GuestViewEvent. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/guest_view_manager.h

diff --git a/extensions/browser/guest_view/guest_view_manager.h b/extensions/browser/guest_view/guest_view_manager.h

index 934c46747dd4656b813caf6118ed1df0fbfac3d9..f68d3f5c73ec19b4c7849622abfda706e84e5661 100644

--- a/extensions/browser/guest_view/guest_view_manager.h

+++ b/extensions/browser/guest_view/guest_view_manager.h

@@ -104,6 +104,11 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

// Can be overriden in tests.

virtual void RemoveGuest(int guest_instance_id);

+ // Indicates whether the provided |guest| can be used in the context it has

+ // been created.

+ bool IsGuestAvailableToContext(GuestViewBase* guest,

+ std::string* owner_extension_id);

content::WebContents* GetGuestByInstanceID(int guest_instance_id);

bool CanEmbedderAccessInstanceIDMaybeKill(