extensions/browser/guest_view/extension_view/extension_view_guest.cc - Issue 1087123002: Towards Decoupling GuestView from Extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_view/extension_view_guest.cc

Issue 1087123002: Towards Decoupling GuestView from Extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lazyboy@'s comments. Removed unnecessary includes. Simplified GuestViewEvent. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/extension_options/extension_options_guest.cc ('k') | extensions/browser/guest_view/guest_view_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_view/extension_view_guest.cc

diff --git a/extensions/browser/guest_view/extension_view/extension_view_guest.cc b/extensions/browser/guest_view/extension_view/extension_view_guest.cc

index 268ce9e79444fb53c5551182e53c406a8deb8987..79922ee2997ea40ec2daeb76fc397373d2c6836f 100644

--- a/extensions/browser/guest_view/extension_view/extension_view_guest.cc

+++ b/extensions/browser/guest_view/extension_view/extension_view_guest.cc

@@ -11,6 +11,7 @@

#include "extensions/browser/api/extensions_api_client.h"

#include "extensions/browser/bad_message.h"

#include "extensions/browser/guest_view/extension_view/extension_view_constants.h"

+#include "extensions/browser/guest_view/guest_view_event.h"

#include "extensions/common/constants.h"

#include "extensions/common/extension_messages.h"

#include "extensions/strings/grit/extensions_strings.h"

@@ -142,7 +143,7 @@ void ExtensionViewGuest::DidCommitProvisionalLoadForFrame(

scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());

args->SetString(guestview::kUrl, relative_url);

DispatchEventToView(

- new GuestViewBase::Event(extensionview::kEventLoadCommit, args.Pass()));

+ new GuestViewEvent(extensionview::kEventLoadCommit, args.Pass()));

}

void ExtensionViewGuest::DidNavigateMainFrame(