Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/platform-macos.cc

Issue 10871039: Replacing circular queue by single buffer in CPU Profiler. (Closed) Base URL: http://git.chromium.org/external/v8.git@profiling
Patch Set: an attempt to fix a test that strangely crashed only once Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 sampler_thread->SampleContext(sampler); 812 sampler_thread->SampleContext(sampler);
813 } 813 }
814 814
815 static void DoRuntimeProfile(Sampler* sampler, void* ignored) { 815 static void DoRuntimeProfile(Sampler* sampler, void* ignored) {
816 if (!sampler->isolate()->IsInitialized()) return; 816 if (!sampler->isolate()->IsInitialized()) return;
817 sampler->isolate()->runtime_profiler()->NotifyTick(); 817 sampler->isolate()->runtime_profiler()->NotifyTick();
818 } 818 }
819 819
820 void SampleContext(Sampler* sampler) { 820 void SampleContext(Sampler* sampler) {
821 thread_act_t profiled_thread = sampler->platform_data()->profiled_thread(); 821 thread_act_t profiled_thread = sampler->platform_data()->profiled_thread();
822 TickSample sample_obj; 822 TickSample* sample = CpuProfiler::StartTickSampleEvent(sampler->isolate());
823 TickSample* sample = CpuProfiler::TickSampleEvent(sampler->isolate()); 823 if (sample == NULL) return;
824 if (sample == NULL) sample = &sample_obj;
825 824
826 if (KERN_SUCCESS != thread_suspend(profiled_thread)) return; 825 if (KERN_SUCCESS != thread_suspend(profiled_thread)) return;
827 826
828 #if V8_HOST_ARCH_X64 827 #if V8_HOST_ARCH_X64
829 thread_state_flavor_t flavor = x86_THREAD_STATE64; 828 thread_state_flavor_t flavor = x86_THREAD_STATE64;
830 x86_thread_state64_t state; 829 x86_thread_state64_t state;
831 mach_msg_type_number_t count = x86_THREAD_STATE64_COUNT; 830 mach_msg_type_number_t count = x86_THREAD_STATE64_COUNT;
832 #if __DARWIN_UNIX03 831 #if __DARWIN_UNIX03
833 #define REGISTER_FIELD(name) __r ## name 832 #define REGISTER_FIELD(name) __r ## name
834 #else 833 #else
(...skipping 16 matching lines...) Expand all
851 flavor, 850 flavor,
852 reinterpret_cast<natural_t*>(&state), 851 reinterpret_cast<natural_t*>(&state),
853 &count) == KERN_SUCCESS) { 852 &count) == KERN_SUCCESS) {
854 sample->state = sampler->isolate()->current_vm_state(); 853 sample->state = sampler->isolate()->current_vm_state();
855 sample->pc = reinterpret_cast<Address>(state.REGISTER_FIELD(ip)); 854 sample->pc = reinterpret_cast<Address>(state.REGISTER_FIELD(ip));
856 sample->sp = reinterpret_cast<Address>(state.REGISTER_FIELD(sp)); 855 sample->sp = reinterpret_cast<Address>(state.REGISTER_FIELD(sp));
857 sample->fp = reinterpret_cast<Address>(state.REGISTER_FIELD(bp)); 856 sample->fp = reinterpret_cast<Address>(state.REGISTER_FIELD(bp));
858 sampler->SampleStack(sample); 857 sampler->SampleStack(sample);
859 sampler->Tick(sample); 858 sampler->Tick(sample);
860 } 859 }
860 CpuProfiler::FinishTickSampleEvent(sampler->isolate());
861 thread_resume(profiled_thread); 861 thread_resume(profiled_thread);
862 } 862 }
863 863
864 const int interval_; 864 const int interval_;
865 RuntimeProfilerRateLimiter rate_limiter_; 865 RuntimeProfilerRateLimiter rate_limiter_;
866 866
867 // Protects the process wide state below. 867 // Protects the process wide state below.
868 static Mutex* mutex_; 868 static Mutex* mutex_;
869 static SamplerThread* instance_; 869 static SamplerThread* instance_;
870 870
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 923
924 924
925 void Sampler::Stop() { 925 void Sampler::Stop() {
926 ASSERT(IsActive()); 926 ASSERT(IsActive());
927 SamplerThread::RemoveActiveSampler(this); 927 SamplerThread::RemoveActiveSampler(this);
928 SetActive(false); 928 SetActive(false);
929 } 929 }
930 930
931 931
932 } } // namespace v8::internal 932 } } // namespace v8::internal
OLDNEW
« src/cpu-profiler-inl.h ('K') | « src/platform-linux.cc ('k') | src/platform-openbsd.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698