Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1087093002: Roll web-page-replay to d6b0f311b2864581e4112ee839086737a51a4dc6. (attempt 2) (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll web-page-replay to 4e4d540a18c099e2ad805696072f95815f313c0e. (attempt 1) For the full list of changes, see https://github.com/chromium/web-page-replay/compare/94d7e2a...4e4d540. WebPageReplay moved the method has_sni() from certutils to platformsettings, and renamed it to HasSniSupport(). This CL fixes the one location where has_sni() is used, and also fixes the stubs. BUG=477130 Committed: https://crrev.com/77ffa479e21ec9393ca7fc69e45f5e3c7630e9eb Cr-Commit-Position: refs/heads/master@{#325313}

Patch Set 1 #

Patch Set 2 : Update DEPs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/system_stub.py View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
erikchen
nednguyen: Please review.
5 years, 8 months ago (2015-04-14 23:46:28 UTC) #2
nednguyen
lgtm
5 years, 8 months ago (2015-04-15 01:14:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087093002/1
5 years, 8 months ago (2015-04-15 01:15:25 UTC) #5
nednguyen
On 2015/04/15 01:15:25, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-15 01:15:55 UTC) #7
erikchen
On 2015/04/15 01:15:55, nednguyen wrote: > On 2015/04/15 01:15:25, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-15 19:58:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087093002/20001
5 years, 8 months ago (2015-04-15 20:00:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087093002/20001
5 years, 8 months ago (2015-04-15 20:05:57 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 21:38:35 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:40:36 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77ffa479e21ec9393ca7fc69e45f5e3c7630e9eb
Cr-Commit-Position: refs/heads/master@{#325313}

Powered by Google App Engine
This is Rietveld 408576698