tools/perf/page_sets/key_desktop_move_cases.py - Issue 1087023003: [Telemetry] Remove action_runner.BeginGestureInteraction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_desktop_move_cases.py

Issue 1087023003: [Telemetry] Remove action_runner.BeginGestureInteraction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_desktop_move_cases.py

diff --git a/tools/perf/page_sets/key_desktop_move_cases.py b/tools/perf/page_sets/key_desktop_move_cases.py

index c322ddf93907748eb5160655a5119061c58755f1..95a48d794f8fa839b064b9ac00c91a35e35a37c7 100644

--- a/tools/perf/page_sets/key_desktop_move_cases.py

+++ b/tools/perf/page_sets/key_desktop_move_cases.py

@@ -51,13 +51,11 @@ class GmailMouseScrollPage(KeyDesktopMoveCasesPage):

'window.__scrollableElementForTelemetry != null')

scrollbar_x, start_y, end_y = self._CalculateScrollBarRatios(action_runner)

- interaction = action_runner.BeginGestureInteraction(

- 'DragAction')

- action_runner.DragPage(left_start_ratio=scrollbar_x,

- top_start_ratio=start_y, left_end_ratio=scrollbar_x,

- top_end_ratio=end_y, speed_in_pixels_per_second=100,

- element_function='window.__scrollableElementForTelemetry')

- interaction.End()

+ with action_runner.CreateGestureInteraction('DragAction'):

+ action_runner.DragPage(left_start_ratio=scrollbar_x,

+ top_start_ratio=start_y, left_end_ratio=scrollbar_x,

+ top_end_ratio=end_y, speed_in_pixels_per_second=100,

+ element_function='window.__scrollableElementForTelemetry')

def _CalculateScrollBarRatios(self, action_runner):

viewport_height = float(action_runner.EvaluateJavaScript(

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/action_runner.py » ('j') | no next file with comments »