Change how NavigationController reloads transient entries

Move browser_command's code to reload transient entries
down into NavigationController::Reload.

This allows other code make use of the code to share
behavior.  In particular, this is needed so the captive portal
detection code can automatically reload a tab showing an SSL
interstitial caused by a captive portal.

BUG=115487, 139966
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154319

[Charlie Reis, 2012-08-27 17:25:35]

LGTM

http://codereview.chromium.org/10870073/diff/8001/content/browser/web_content...
File content/browser/web_contents/navigation_controller_impl.cc (right):

http://codereview.chromium.org/10870073/diff/8001/content/browser/web_content...
content/browser/web_contents/navigation_controller_impl.cc:252: // Interstitials
are reloaded by navigating back to their URLs.
Maybe clarify this as "If an interstitial is showing, treat a reload as a
navigation to the transient entry's URL."  (I got confused at first, thinking
the interstitial's URL was the data URL for the warning page.)

[mmenke, 2012-08-27 17:37:03]

http://codereview.chromium.org/10870073/diff/8001/content/browser/web_content...
File content/browser/web_contents/navigation_controller_impl.cc (right):

http://codereview.chromium.org/10870073/diff/8001/content/browser/web_content...
content/browser/web_contents/navigation_controller_impl.cc:252: // Interstitials
are reloaded by navigating back to their URLs.
On 2012/08/27 17:25:35, creis wrote:
> Maybe clarify this as "If an interstitial is showing, treat a reload as a
> navigation to the transient entry's URL."  (I got confused at first, thinking
> the interstitial's URL was the data URL for the warning page.)

Done.

[commit-bot: I haz the power, 2012-08-30 19:28:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10870073/2007

[commit-bot: I haz the power, 2012-08-30 19:28:17]

Presubmit check for 10870073-2007 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

[mmenke, 2012-08-30 19:53:13]

[+ben]

Ben:  Could you do an owners review for the change to
chrome/browser/ui/browser_commands.cc?  I've moved the behavior down into the
navigation_controller.  Thanks.

[Ben Goodger (Google), 2012-08-30 21:21:16]

lgtm

[commit-bot: I haz the power, 2012-08-30 21:27:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10870073/2007

[commit-bot: I haz the power, 2012-08-30 23:57:38]

Change committed as 154319