Issue 1087003002: Switch print preview to in browser mdns for per-user Chrome installs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1087003002: Switch print preview to in browser mdns for per-user Chrome installs (Closed)

Created:
5 years, 8 months ago by Vitaly Buka (NO REVIEWS)

Modified:
5 years, 8 months ago

Reviewers:
Aleksey Shlyapnikov

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Switch print preview to in browser mdns for per-user Chrome installs chrome.mdns API and chrome://devices already works this way This may trigger some Windows Firewall allerts. BUG=349645 Committed: https://crrev.com/7c803a908809b7197ad7b077a50fa2a6634d9a6b Cr-Commit-Position: refs/heads/master@{#325505}

Patch Set 1 #

Patch Set 2 : Tue Apr 14 12:02:10 PDT 2015 #

Patch Set 3 : Tue Apr 14 12:03:18 PDT 2015 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1087003002/40001

5 years, 8 months ago (2015-04-16 19:11:55 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 20:13:16 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/7c803a908809b7197ad7b077a50fa2a6634d9a6b
Cr-Commit-Position: refs/heads/master@{#325505}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages