Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: sky/framework/fn.dart

Issue 1086983004: [Effen] We need to update the layout manager in _syncNode() also, (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update per ojan's comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/fn.dart
diff --git a/sky/framework/fn.dart b/sky/framework/fn.dart
index 43df942099d68a08d35bfa0780bb358fb63f062b..e7ff992764452bb1a800b87056b9c618b26f41c3 100644
--- a/sky/framework/fn.dart
+++ b/sky/framework/fn.dart
@@ -607,8 +607,12 @@ abstract class LayoutContainer extends Container {
return result;
}
+ // If we ever reuse sky nodes for different classes, then we should
+ // call _root.setLayoutManager(null) during _remove() here.
+
void _syncNode(SkyNodeWrapper old) {
super._syncNode(old);
+ _root.setLayoutManager(() => layout(_root));
_root.setNeedsLayout();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698