[Extensions Mac] Implement developer mode warning on mac

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 
 #include <string>
 
 #include "base/strings/sys_string_conversions.h"
+#include "chrome/browser/extensions/extension_message_bubble_controller.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h"
+#import "chrome/browser/ui/cocoa/extensions/extension_message_bubble_bridge.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
-#import "chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac.h"
+#import "chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h"
 #import "chrome/browser/ui/cocoa/image_button_cell.h"
 #import "chrome/browser/ui/cocoa/menu_button.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
+#include "chrome/browser/ui/extensions/extension_toolbar_icon_surfacing_bubble_delegate.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h"
 #include "grit/theme_resources.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h"
 
 NSString* const kBrowserActionVisibilityChangedNotification =
     @"BrowserActionVisibilityChangedNotification";
 
@@ skipping 104 matching lines @@
 
 // Handles when a menu item within the chevron overflow menu is selected.
 - (void)chevronItemSelected:(id)menuItem;
 
 // Updates the container's grippy cursor based on the number of hidden buttons.
 - (void)updateGrippyCursors;
 
 // Returns the associated ToolbarController.
 - (ToolbarController*)toolbarController;
 
+// Creates a message bubble anchored to the first action in the toolbar (or the
+// overflow menu, if no actions are present).
+- (ToolbarActionsBarBubbleMac*)createMessageBubble:
+    (scoped_ptr<ToolbarActionsBarBubbleDelegate>)delegate;
+
 @end
 
 namespace {
 
 // A bridge between the ToolbarActionsBar and the BrowserActionsController.
 class ToolbarActionsBarBridge : public ToolbarActionsBarDelegate {
  public:
   explicit ToolbarActionsBarBridge(BrowserActionsController* controller);
   ~ToolbarActionsBarBridge() override;
 
@@ skipping 92 matching lines @@
 }
 
 void ToolbarActionsBarBridge::OnOverflowedActionWantsToRunChanged(
     bool overflowed_action_wants_to_run) {
   [[controller_ toolbarController]
       setOverflowedToolbarActionWantsToRun:overflowed_action_wants_to_run];
 }
 
 void ToolbarActionsBarBridge::ShowExtensionMessageBubble(
     scoped_ptr<extensions::ExtensionMessageBubbleController> controller) {
-  NOTREACHED();  // Not yet implemented on Mac.
+  // This goop is a by-product of needing to wire together abstract classes,
+  // C++/Cocoa bridges, and ExtensionMessageBubbleController's somewhat strange
+  // Show() interface. It's ugly, but it's pretty confined, so it's probably
+  // okay (but if we ever need to expand, it might need to be reconsidered).
+  scoped_ptr<ExtensionMessageBubbleBridge> bridge(
+      new ExtensionMessageBubbleBridge(controller.Pass()));
+  ExtensionMessageBubbleBridge* weak_bridge = bridge.get();
+  ToolbarActionsBarBubbleMac* bubble =
+      [controller_ createMessageBubble:bridge.Pass()];
+  weak_bridge->SetBubble(bubble);
+  weak_bridge->controller()->Show(weak_bridge);
 }
 
 }  // namespace
 
 @implementation BrowserActionsController
 
 @synthesize containerView = containerView_;
 @synthesize browser = browser_;
 @synthesize isOverflow = isOverflow_;
 
@@ skipping 51 matching lines @@
     }
 
     if (isOverflow_)
       toolbarActionsBar_->SetOverflowRowWidth(NSWidth([containerView_ frame]));
 
     buttons_.reset([[NSMutableArray alloc] init]);
     toolbarActionsBar_->CreateActions();
     [self showChevronIfNecessaryInFrame:[containerView_ frame]];
     [self updateGrippyCursors];
     [container setResizable:!isOverflow_];
-    if (toolbarActionsBar_->ShouldShowInfoBubble()) {
+    if (ExtensionToolbarIconSurfacingBubbleDelegate::ShouldShowForProfile(
+            browser_->profile())) {
       [containerView_ setTrackingEnabled:YES];
       [[NSNotificationCenter defaultCenter]
           addObserver:self
              selector:@selector(containerMouseEntered:)
                  name:kBrowserActionsContainerMouseEntered
                object:containerView_];
     }
   }
 
   return self;
@@ skipping 142 matching lines @@
              name:kBrowserActionButtonDraggingNotification
            object:newButton];
 
   [containerView_ setMaxDesiredWidth:toolbarActionsBar_->GetMaximumWidth()];
 }
 
 - (void)redraw {
   if (![self updateContainerVisibility])
     return;  // Container is hidden; no need to update.
 
+  [containerView_ setIsHighlighting:toolbarActionsBar_->is_highlighting()];
+
   std::vector<ToolbarActionViewController*> toolbar_actions =
       toolbarActionsBar_->toolbar_actions();
   for (NSUInteger i = 0; i < [buttons_ count]; ++i) {
     if ([[buttons_ objectAtIndex:i] viewController] != toolbar_actions[i]) {
       size_t j = i + 1;
       while (toolbar_actions[i] != [[buttons_ objectAtIndex:j] viewController])
         ++j;
       [buttons_ exchangeObjectAtIndex:i withObjectAtIndex: j];
     }
   }
@@ skipping 162 matching lines @@
   }
 
   toolbarActionsBar_->OnResizeComplete(
       toolbarActionsBar_->IconCountToWidth([self visibleButtonCount]));
 
   [self updateGrippyCursors];
   [self resizeContainerToWidth:toolbarActionsBar_->GetPreferredSize().width()];
 }
 
 - (void)containerMouseEntered:(NSNotification*)notification {
-  if (toolbarActionsBar_->ShouldShowInfoBubble()) {
-    NSPoint anchor = [self popupPointForId:[[buttons_ objectAtIndex:0]
-                                               viewController]->GetId()];
-    anchor = [[containerView_ window] convertBaseToScreen:anchor];
-    ExtensionToolbarIconSurfacingBubbleMac* bubble =
-        [[ExtensionToolbarIconSurfacingBubbleMac alloc]
-            initWithParentWindow:[containerView_ window]
-                     anchorPoint:anchor
-                        delegate:toolbarActionsBar_.get()];
+  if (ExtensionToolbarIconSurfacingBubbleDelegate::ShouldShowForProfile(
+          browser_->profile())) {
+    ToolbarActionsBarBubbleMac* bubble =
+        [self createMessageBubble:scoped_ptr<ToolbarActionsBarBubbleDelegate>(
+            new ExtensionToolbarIconSurfacingBubbleDelegate(
+                browser_->profile()))];
     [bubble showWindow:nil];
   }
   [containerView_ setTrackingEnabled:NO];
   [[NSNotificationCenter defaultCenter]
       removeObserver:self
                 name:kBrowserActionsContainerMouseEntered
               object:containerView_];
 }
 
 - (void)actionButtonDragging:(NSNotification*)notification {
@@ skipping 169 matching lines @@
       setCanDragLeft:toolbarActionsBar_->GetIconCount() != [buttons_ count]];
   [containerView_ setCanDragRight:[self visibleButtonCount] > 0];
   [[containerView_ window] invalidateCursorRectsForView:containerView_];
 }
 
 - (ToolbarController*)toolbarController {
   return [[BrowserWindowController browserWindowControllerForWindow:
              browser_->window()->GetNativeWindow()] toolbarController];
 }
 
+- (ToolbarActionsBarBubbleMac*)createMessageBubble:
+    (scoped_ptr<ToolbarActionsBarBubbleDelegate>)delegate {
+  DCHECK_GE([buttons_ count], 0u);
+  NSPoint anchor = [self popupPointForId:[[buttons_ objectAtIndex:0]
+                                             viewController]->GetId()];
+  anchor = [[containerView_ window] convertBaseToScreen:anchor];
+  return [[ToolbarActionsBarBubbleMac alloc]
+      initWithParentWindow:[containerView_ window]
+               anchorPoint:anchor
+                  delegate:delegate.Pass()];
+}
+
 
 #pragma mark -
 #pragma mark Testing Methods
 
 - (BrowserActionButton*)buttonWithIndex:(NSUInteger)index {
   return index < [buttons_ count] ? [buttons_ objectAtIndex:index] : nil;
 }
 
 - (ToolbarActionsBar*)toolbarActionsBar {
   return toolbarActionsBar_.get();
 }
 
 + (BrowserActionsController*)fromToolbarActionsBarDelegate:
     (ToolbarActionsBarDelegate*)delegate {
   return static_cast<ToolbarActionsBarBridge*>(delegate)->controller_for_test();
 }
 
 @end