[Extensions Mac] Implement developer mode warning on mac

[Extensions Mac] Implement developer mode warning on mac

Implement the developer mode warning on mac.
Instead of creating yet-another-bubble-class, refactor the bubble we used for
the toolbar redesign. This includes:
- Expanding ToolbarActionsBarBubbleDelegate.
- Moving the logic for showing the redesign bubble into a new class.
- Updating the redesign bubble to have a more flexible UI (and renaming it to
  ToolbarActionsBarBubble).
Hook up the ToolbarActionsBarBubble for use with ExtensionMessageBubbles, and
implement the highlighting on the toolbar.

Note that this does *not* turn the feature on for mac.

TBR=benwells@chromium.org (OWNERS file change)

BUG=474092
Committed: https://crrev.com/b6e393967429379375c0a92973f0f367c29500de
Cr-Commit-Position: refs/heads/master@{#325549}

[Devlin, 2015-04-15 16:58:19]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-04-15 23:54:29]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-04-15 23:54:35]

Patchset #1 (id:40001) has been deleted

[Devlin, 2015-04-15 23:54:41]

Patchset #1 (id:60001) has been deleted

[Devlin, 2015-04-15 23:54:47]

Patchset #1 (id:80001) has been deleted

[Devlin, 2015-04-15 23:54:52]

Patchset #1 (id:100001) has been deleted

[Devlin, 2015-04-15 23:54:58]

Patchset #1 (id:120001) has been deleted

[Devlin, 2015-04-15 23:55:05]

Patchset #1 (id:140001) has been deleted

[Devlin, 2015-04-16 00:05:33]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2015-04-16 00:05:34]

Finnur, mind taking a look? (I'll have Avi take the cocoa.)  Sorry about the
size -- a few hundred lines is just moving code around (most noticeably, from
ToolbarActionsBar into ExtensionToolbarIconSurfacingBubbleDelegate).  If your
head starts to hurt, I can look for a way to split it up. :)

[Finnur, 2015-04-16 09:52:09]

You'll need someone to look over the Mac code but once the potentially
accidental change has been addressed, this LGTM.

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/exte...
File chrome/browser/ui/extensions/extension_message_bubble_factory.cc (right):

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/exte...
chrome/browser/ui/extensions/extension_message_bubble_factory.cc:29: bool
g_enabled = true;
Accidental?

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h
(right):

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h:27: void
set_learn_more_button(const base::string16& learn_more) {
Nit: It feels like these functions need a _text or _label suffix.

[Devlin, 2015-04-16 15:59:51]

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/exte...
File chrome/browser/ui/extensions/extension_message_bubble_factory.cc (right):

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/exte...
chrome/browser/ui/extensions/extension_message_bubble_factory.cc:29: bool
g_enabled = true;
On 2015/04/16 09:52:09, Finnur wrote:
> Accidental?

Completely. :)

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h
(right):

https://codereview.chromium.org/1086973004/diff/180001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h:27: void
set_learn_more_button(const base::string16& learn_more) {
On 2015/04/16 09:52:09, Finnur wrote:
> Nit: It feels like these functions need a _text or _label suffix.

Done.

[Devlin, 2015-04-16 16:02:38]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2015-04-16 16:02:38]

Avi, mind taking a look at the Cocoa?

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
(right):

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm:79:
ui::NinePartImageIds imageIds = IMAGE_GRID(IDR_DEVELOPER_MODE_HIGHLIGHT);
Avi, is this there a better way of doing this?

[Avi (use Gerrit), 2015-04-16 19:05:54]

LGTM, just nits.

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/extensi...
File chrome/browser/extensions/extension_message_bubble.h (right):

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/extension_message_bubble.h:14: // The interface
between the SuspiciousExtensionBubble bubble and its
Is this reference to "SuspiciousExtensionBubble" still correct?

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/extension_message_bubble.h:22: virtual
~ExtensionMessageBubble() {}
We didn't already have a virtual destructor here? Yikes.

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
(right):

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm:79:
ui::NinePartImageIds imageIds = IMAGE_GRID(IDR_DEVELOPER_MODE_HIGHLIGHT);
On 2015/04/16 16:02:38, Devlin wrote:
> Avi, is this there a better way of doing this?

That seems to be how it's done elsewhere.

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
(right):

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm:33: //
Creates an NSTextField with the given string, size, and alignment,, and adds
fix ,,

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm:217:
isPrimary:NO];
align on :

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm:224:
isPrimary:YES];
align on :

[Devlin, 2015-04-16 22:40:59]

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/extensi...
File chrome/browser/extensions/extension_message_bubble.h (right):

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/extension_message_bubble.h:14: // The interface
between the SuspiciousExtensionBubble bubble and its
On 2015/04/16 19:05:54, Avi wrote:
> Is this reference to "SuspiciousExtensionBubble" still correct?

Updated.

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
(right):

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm:79:
ui::NinePartImageIds imageIds = IMAGE_GRID(IDR_DEVELOPER_MODE_HIGHLIGHT);
On 2015/04/16 19:05:54, Avi wrote:
> On 2015/04/16 16:02:38, Devlin wrote:
> > Avi, is this there a better way of doing this?
> 
> That seems to be how it's done elsewhere.

It's a shame we have to draw the whole background (when in theory we could only
draw |rect|), but luckily we don't do this very often, or for very long.

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
(right):

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm:33: //
Creates an NSTextField with the given string, size, and alignment,, and adds
On 2015/04/16 19:05:54, Avi wrote:
> fix ,,

Done.

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm:217:
isPrimary:NO];
On 2015/04/16 19:05:54, Avi wrote:
> align on :

Whoops! Must have forgot to fix indent after a variable rename.  Done.

https://codereview.chromium.org/1086973004/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm:224:
isPrimary:YES];
On 2015/04/16 19:05:54, Avi wrote:
> align on :

Done.

[Devlin, 2015-04-16 22:41:03]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-04-16 22:41:03]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1086973004/#ps220001
(title: "Avi's")

[commit-bot: I haz the power, 2015-04-16 22:42:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1086973004/220001

[commit-bot: I haz the power, 2015-04-16 23:28:55]

Committed patchset #4 (id:220001)

[commit-bot: I haz the power, 2015-04-16 23:29:43]

Patchset 4 (id:??) landed as
https://crrev.com/b6e393967429379375c0a92973f0f367c29500de
Cr-Commit-Position: refs/heads/master@{#325549}