Regularize lmp::XXX_element_handler.

Regularize lmp::XXX_element_handler.

This makes all non-XMLCALL element_handler functions uniform by making
their signature

void XXX_element_handler(FamilyData* self, const char** attributes)

This makes the code somewhat easier to follow, as it makes explicit
which functions are actually logically methods of FamilyData (start
with 'FamilyData* self') and which are called directly by expat
(start with 'void* data').

Committed: https://skia.googlesource.com/skia/+/e1ddb3b190697a26154bff207fce2189c8be6d30

[bungeman-skia, 2015-04-17 21:18:50]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-04-17 21:19:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1086943007/1

[bungeman-skia, 2015-04-17 21:19:53]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[commit-bot: I haz the power, 2015-04-17 21:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 21:28:13]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-04-17 22:20:16]

bungeman@google.com changed reviewers:
+ tomhudson@google.com

[tomhudson, 2015-04-20 18:11:39]

https://codereview.chromium.org/1086943007/diff/1/src/ports/SkFontConfigParse...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/1086943007/diff/1/src/ports/SkFontConfigParse...
src/ports/SkFontConfigParser_android.cpp:123: family.fIsFallbackFont = true;
Why are you making /family/ a reference instead of a pointer?

[bungeman-skia, 2015-04-20 20:14:57]

How about like this?

https://codereview.chromium.org/1086943007/diff/1/src/ports/SkFontConfigParse...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/1086943007/diff/1/src/ports/SkFontConfigParse...
src/ports/SkFontConfigParser_android.cpp:123: family.fIsFallbackFont = true;
On 2015/04/20 18:11:39, tomhudson wrote:
> Why are you making /family/ a reference instead of a pointer?

Mostly for consistency with font_element_handler, though it turns out the real
reason for that inconsistency is that one gets held in a SkTArray and other in
an SkTDArray, which is something which should also be fixed. I took a look into
fixing that, but that's another CL. I'll just leave this a pointer for no then.

[tomhudson, 2015-04-20 20:26:17]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2015-04-20 20:26:17]

lgtm

[commit-bot: I haz the power, 2015-04-20 20:26:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1086943007/20001

[commit-bot: I haz the power, 2015-04-20 20:31:59]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e1ddb3b190697a26154bff207fce2189c8be6d30