Issue 1086923002: %GetOptimizationStatus(): Unconditionally return a sentinel when --always-opt is present

Issue 1086923002: %GetOptimizationStatus(): Unconditionally return a sentinel when --always-opt is present (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow

Modified:
5 years, 8 months ago

Reviewers:
mvstanton, Michael Achenbach

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

%GetOptimizationStatus(): Unconditionally return a sentinel when --always-opt is present Committed: https://crrev.com/3eb277f270b9d41967e7ac208ec3fe8ef233761a Cr-Commit-Position: refs/heads/master@{#27822}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -14 lines)			Patch
M	src/runtime/runtime-test.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	test/mjsunit/array-constructor-feedback.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/array-feedback.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/compiler/inlined-call.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/compiler/inlined-call-mapcheck.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/compiler/regress-gvn.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/double-intrinsics.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/es6/block-let-crankshaft.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-320532.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-385565.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-crbug-245480.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 9 (3 generated)

Jakob Kummerow

PTAL. There are a few more tests that specify --noalways-opt; they seem to require it ...

5 years, 8 months ago (2015-04-14 12:20:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086923002/1

5 years, 8 months ago (2015-04-14 14:32:28 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/3eb277f270b9d41967e7ac208ec3fe8ef233761a Cr-Commit-Position: refs/heads/master@{#27822}

5 years, 8 months ago (2015-04-14 14:58:10 UTC) #7

Michael Achenbach

5 years, 8 months ago (2015-04-15 08:41:04 UTC) #9

Message was sent while issue was closed.

FYI: This seems to introduce a failure here:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim...