Always wrap AllocationSiteContext::current() in a new handle in Crankshaft.

Always wrap AllocationSiteContext::current() in a new handle in Crankshaft.

R=mvstanton@chromium.org
BUG=

Committed: https://crrev.com/7a4744ade43ede9541e10807f744ad766866747f
Cr-Commit-Position: refs/heads/master@{#27935}

[titzer, 2015-04-20 09:43:15]

https://codereview.chromium.org/1086863003/diff/1/src/allocation-site-scopes.h
File src/allocation-site-scopes.h (left):

https://codereview.chromium.org/1086863003/diff/1/src/allocation-site-scopes....
src/allocation-site-scopes.h:78: DCHECK(nested_site->IsAllocationSite());
This check was redundant since it's implied in the AllocationSite::cast() below.

[mvstanton, 2015-04-20 10:14:53]

LGTM. thanks for fixing this!

nit, as we discussed: if current() returns an AllocationSite* instead of
Handle<AllocationSite>, then no one else can walk into the situation of
embedding an "unembeddable" pointer.

[titzer, 2015-04-20 10:54:13]

On 2015/04/20 10:14:53, mvstanton wrote:
> LGTM. thanks for fixing this!
> 
> nit, as we discussed: if current() returns an AllocationSite* instead of
> Handle<AllocationSite>, then no one else can walk into the situation of
> embedding an "unembeddable" pointer.

Next CL, hopefully not too far in the future :-)

[titzer, 2015-04-20 11:47:03]

Committed patchset #1 (id:1) manually as
7a4744ade43ede9541e10807f744ad766866747f (presubmit successful).

[commit-bot: I haz the power, 2015-04-20 11:47:04]

Patchset 1 (id:??) landed as
https://crrev.com/7a4744ade43ede9541e10807f744ad766866747f
Cr-Commit-Position: refs/heads/master@{#27935}