Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: content/browser/gpu/gpu_process_host_ui_shim.h

Issue 108683003: Store gpu crashes in the systemprofileproto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Alexei comments1 Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_process_host_ui_shim.h
diff --git a/content/browser/gpu/gpu_process_host_ui_shim.h b/content/browser/gpu/gpu_process_host_ui_shim.h
index bd7da0a37c39ca885067e41d1128c09c71932ec2..43eda2633135f2feafa5c8d664c5907871feaf1a 100644
--- a/content/browser/gpu/gpu_process_host_ui_shim.h
+++ b/content/browser/gpu/gpu_process_host_ui_shim.h
@@ -16,6 +16,7 @@
#include "base/compiler_specific.h"
#include "base/memory/linked_ptr.h"
#include "base/memory/ref_counted.h"
+#include "base/process/kill.h"
#include "base/threading/non_thread_safe.h"
#include "content/common/content_export.h"
#include "content/common/message_router.h"
@@ -53,8 +54,10 @@ class GpuProcessHostUIShim : public IPC::Listener,
// Destroy the GpuProcessHostUIShim with the given host ID. This can only
// be called on the UI thread. Only the GpuProcessHost should destroy the
- // UI shim.
- static void Destroy(int host_id, const std::string& message);
+ // UI shim. We also pass in the status of the GPU termination.
Alexei Svitkine (slow) 2013/12/16 16:04:28 Nit: Describe the params without using "we" (and d
rkaplow 2013/12/16 16:39:54 good point, thanks
+ static void Destroy(int host_id,
+ base::TerminationStatus status,
+ const std::string& message);
// Destroy all remaining GpuProcessHostUIShims.
CONTENT_EXPORT static void DestroyAll();
@@ -85,8 +88,9 @@ class GpuProcessHostUIShim : public IPC::Listener,
// Message handlers.
bool OnControlMessageReceived(const IPC::Message& message);
- void OnLogMessage(int level, const std::string& header,
- const std::string& message);
+ void OnLogMessage(int level,
+ const std::string& header,
+ const std::string& message);
void OnResizeView(int32 surface_id,
int32 route_id,
gfx::Size size);

Powered by Google App Engine
This is Rietveld 408576698