Store gpu crashes in the systemprofileproto

content/browser/gpu/gpu_process_host_ui_shim.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu/gpu_process_host_ui_shim.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/id_map.h"
 #include "base/lazy_instance.h"
+#include "base/process/kill.h"
 #include "base/strings/string_number_conversions.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/browser/gpu/gpu_process_host.h"
 #include "content/browser/gpu/gpu_surface_tracker.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "content/port/browser/render_widget_host_view_port.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_types.h"
 #include "ui/gl/gl_switches.h"
 
 // From gl2/gl2ext.h.
 #ifndef GL_MAILBOX_SIZE_CHROMIUM
 #define GL_MAILBOX_SIZE_CHROMIUM 64
 #endif
 
 namespace content {
 
 namespace {
@@ skipping 66 matching lines @@
   g_hosts_by_id.Pointer()->AddWithID(this, host_id_);
 }
 
 // static
 GpuProcessHostUIShim* GpuProcessHostUIShim::Create(int host_id) {
   DCHECK(!FromID(host_id));
   return new GpuProcessHostUIShim(host_id);
 }
 
 // static
-void GpuProcessHostUIShim::Destroy(int host_id, const std::string& message) {
+void GpuProcessHostUIShim::Destroy(int host_id,
+                                   base::TerminationStatus status,
+                                   const std::string& message) {
+  // Send a notification if the GPU process did not turn down normally. This
+  // is used to signal a gpu crash to the metrics service.
+  if (status != base::TERMINATION_STATUS_NORMAL_TERMINATION) {
+    content::NotificationService::current()->Notify(

[piman, 2013/12/16 22:12:04]

We're moving away from the Notification pattern, at least in content/ (see
discussions in chromium-dev). Can this be done with an Observer pattern, or by
registering a Callback?

[Ilya Sherman, 2013/12/16 23:04:39]

+1

+        content::NOTIFICATION_GPU_PROCESS_CLOSED_ABNORMALLY,
+        NotificationService::AllSources(),
+        NotificationService::NoDetails());
+  }
+
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   GpuDataManagerImpl::GetInstance()->AddLogMessage(
       logging::LOG_ERROR, "GpuProcessHostUIShim",
       message);
 
   delete FromID(host_id);
 }
 
 // static
@@ skipping 246 matching lines @@
   view->AcceleratedSurfaceRelease();
 }
 
 void GpuProcessHostUIShim::OnVideoMemoryUsageStatsReceived(
     const GPUVideoMemoryUsageStats& video_memory_usage_stats) {
   GpuDataManagerImpl::GetInstance()->UpdateVideoMemoryUsageStats(
       video_memory_usage_stats);
 }
 
 }  // namespace content