Store gpu crashes in the systemprofileproto

chrome/browser/metrics/metrics_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
 //
 // A MetricsService instance is typically created at application startup.  It is
@@ skipping 428 matching lines @@
   registry->RegisterIntegerPref(prefs::kStabilityRendererCrashCount, 0);
   registry->RegisterIntegerPref(prefs::kStabilityExtensionRendererCrashCount,
                                 0);
   registry->RegisterIntegerPref(prefs::kStabilityRendererHangCount, 0);
   registry->RegisterIntegerPref(prefs::kStabilityChildProcessCrashCount, 0);
   registry->RegisterIntegerPref(prefs::kStabilityBreakpadRegistrationFail, 0);
   registry->RegisterIntegerPref(prefs::kStabilityBreakpadRegistrationSuccess,
                                 0);
   registry->RegisterIntegerPref(prefs::kStabilityDebuggerPresent, 0);
   registry->RegisterIntegerPref(prefs::kStabilityDebuggerNotPresent, 0);
+  registry->RegisterIntegerPref(prefs::kStabilityGpuCrashCount, 0);
 #if defined(OS_CHROMEOS)
   registry->RegisterIntegerPref(prefs::kStabilityOtherUserCrashCount, 0);
   registry->RegisterIntegerPref(prefs::kStabilityKernelCrashCount, 0);
   registry->RegisterIntegerPref(prefs::kStabilitySystemUncleanShutdownCount, 0);
 #endif  // OS_CHROMEOS
 
   registry->RegisterStringPref(prefs::kStabilitySavedSystemProfile,
                                std::string());
   registry->RegisterStringPref(prefs::kStabilitySavedSystemProfileHash,
                                std::string());
@@ skipping 20 matching lines @@
   local_state->SetInteger(prefs::kStabilityBreakpadRegistrationFail, 0);
   local_state->SetInteger(prefs::kStabilityDebuggerPresent, 0);
   local_state->SetInteger(prefs::kStabilityDebuggerNotPresent, 0);
 
   local_state->SetInteger(prefs::kStabilityLaunchCount, 0);
   local_state->SetInteger(prefs::kStabilityCrashCount, 0);
 
   local_state->SetInteger(prefs::kStabilityPageLoadCount, 0);
   local_state->SetInteger(prefs::kStabilityRendererCrashCount, 0);
   local_state->SetInteger(prefs::kStabilityRendererHangCount, 0);
+  local_state->SetInteger(prefs::kStabilityGpuCrashCount, 0);
 
   local_state->SetInt64(prefs::kStabilityLaunchTimeSec, 0);
   local_state->SetInt64(prefs::kStabilityLastTimestampSec, 0);
 
   local_state->ClearPref(prefs::kStabilityPluginStats);
 
   local_state->ClearPref(prefs::kMetricsInitialLogs);
   local_state->ClearPref(prefs::kMetricsOngoingLogs);
 }
 
@@ skipping 169 matching lines @@
   registrar->Add(observer, chrome::NOTIFICATION_TAB_PARENTED,
                  content::NotificationService::AllSources());
   registrar->Add(observer, chrome::NOTIFICATION_TAB_CLOSING,
                  content::NotificationService::AllSources());
   registrar->Add(observer, content::NOTIFICATION_LOAD_START,
                  content::NotificationService::AllSources());
   registrar->Add(observer, content::NOTIFICATION_LOAD_STOP,
                  content::NotificationService::AllSources());
   registrar->Add(observer, content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
                  content::NotificationService::AllSources());
+  registrar->Add(observer, content::NOTIFICATION_GPU_PROCESS_CLOSED,
+                 content::NotificationService::AllSources());
   registrar->Add(observer, content::NOTIFICATION_RENDER_WIDGET_HOST_HANG,
                  content::NotificationService::AllSources());
   registrar->Add(observer, chrome::NOTIFICATION_OMNIBOX_OPENED_URL,
                  content::NotificationService::AllSources());
 }
 
 void MetricsService::BrowserChildProcessHostConnected(
     const content::ChildProcessData& data) {
   GetChildProcessStats(data).process_launches++;
 }
@@ skipping 55 matching lines @@
       break;
 
     case chrome::NOTIFICATION_OMNIBOX_OPENED_URL: {
       MetricsLog* current_log =
           static_cast<MetricsLog*>(log_manager_.current_log());
       DCHECK(current_log);
       current_log->RecordOmniboxOpenedURL(
           *content::Details<OmniboxLog>(details).ptr());
       break;
     }
+    case content::NOTIFICATION_GPU_PROCESS_CLOSED: {

[Alexei Svitkine (slow), 2013/12/13 22:37:22]

Nit: blank line before this; also {}'s unnecessary.

[rkaplow, 2013/12/13 23:54:03]

ok, was following most of the style from this method actually but the short ones
don't have so makes sense.

+      LogGpuCrash();
+      break;
+    }
 
     default:
       NOTREACHED();
       break;
   }
 
   HandleIdleSinceLastTransmission(false);
 }
 
 void MetricsService::HandleIdleSinceLastTransmission(bool in_idle) {
@@ skipping 960 matching lines @@
       }
       return;
     }
   }
 
   SyntheticTrialGroup trial_group(
       trial.id.name, trial.id.group, base::TimeTicks::Now());
   synthetic_trial_groups_.push_back(trial_group);
 }
 
+void MetricsService::LogGpuCrash() {
+  IncrementPrefValue(prefs::kStabilityGpuCrashCount);
+}
+
 void MetricsService::GetCurrentSyntheticFieldTrials(
     std::vector<chrome_variations::ActiveGroupId>* synthetic_trials) {
   DCHECK(synthetic_trials);
   synthetic_trials->clear();
   const MetricsLog* current_log =
       static_cast<const MetricsLog*>(log_manager_.current_log());
   for (size_t i = 0; i < synthetic_trial_groups_.size(); ++i) {
     if (synthetic_trial_groups_[i].start_time <= current_log->creation_time())
       synthetic_trials->push_back(synthetic_trial_groups_[i].id);
   }
@@ skipping 189 matching lines @@
   if (local_state) {
     const PrefService::Preference* uma_pref =
         local_state->FindPreference(prefs::kMetricsReportingEnabled);
     if (uma_pref) {
       bool success = uma_pref->GetValue()->GetAsBoolean(&result);
       DCHECK(success);
     }
   }
   return result;
 }