Use xmlAtom / starAtom when possible instead of string literals

Use xmlAtom / starAtom when possible instead of string literals

Use xmlAtom / starAtom when possible instead of string literals. When comparing
to another AtomicString, this avoids doing a character by character comparison,
as we can do a faster pointer comparison instead. This also gets rid of a
redundant static variable.

R=eseidel

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163359

[eseidel, 2013-12-06 18:32:42]

lgtm

On Fri, Dec 6, 2013 at 10:09 AM,  <ch.dumez@samsung.com> wrote:
> Reviewers: eseidel,
>
> Description:
> Use xmlAtom / starAtom when possible instead of string literals
>
> Use xmlAtom / starAtom when possible instead of string literals. When
> comparing
> to another AtomicString, this avoids doing a character by character
> comparison,
> as we can do a faster pointer comparison instead. This also gets rid of a
> redundant static variable.
>
> R=eseidel
>
> Please review this at https://codereview.chromium.org/108683002/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+5, -7 lines):
>   M Source/core/fetch/CrossOriginAccessControl.cpp
>   M Source/core/svg/SVGLangSpace.cpp
>   M Source/core/timing/Performance.cpp
>
>
> Index: Source/core/fetch/CrossOriginAccessControl.cpp
> diff --git a/Source/core/fetch/CrossOriginAccessControl.cpp
> b/Source/core/fetch/CrossOriginAccessControl.cpp
> index
>
90c032352de04f55b34a5a3705dbaa815f5275d4..4cabcb9841f213e3d3fd6a505a6d9da1a039792f
> 100644
> --- a/Source/core/fetch/CrossOriginAccessControl.cpp
> +++ b/Source/core/fetch/CrossOriginAccessControl.cpp
> @@ -142,12 +142,12 @@ bool passesAccessControlCheck(const ResourceResponse&
> response, StoredCredential
>      // A wildcard Access-Control-Allow-Origin can not be used if
> credentials are to be sent,
>      // even with Access-Control-Allow-Credentials set to true.
>      const AtomicString& accessControlOriginString =
> response.httpHeaderField(accessControlAllowOrigin);
> -    if (accessControlOriginString == "*" && includeCredentials ==
> DoNotAllowStoredCredentials)
> +    if (accessControlOriginString == starAtom && includeCredentials ==
> DoNotAllowStoredCredentials)
>          return true;
>
>      // FIXME: Access-Control-Allow-Origin can contain a list of origins.
>      if (accessControlOriginString != securityOrigin->toString()) {
> -        if (accessControlOriginString == "*") {
> +        if (accessControlOriginString == starAtom) {
>              errorDescription = "Wildcards cannot be used in the
> 'Access-Control-Allow-Origin' header when the credentials flag is true.
> Origin '" + securityOrigin->toString() + "' is therefore not allowed
> access.";
>          } else if (accessControlOriginString.isEmpty()) {
>              errorDescription = "No 'Access-Control-Allow-Origin' header is
> present on the requested resource. Origin '" + securityOrigin->toString() +
> "' is therefore not allowed access.";
> Index: Source/core/svg/SVGLangSpace.cpp
> diff --git a/Source/core/svg/SVGLangSpace.cpp
> b/Source/core/svg/SVGLangSpace.cpp
> index
>
feba88ee2ebce78bfb5a3b7dd1f1e7a84b882d20..1fe66e029bb8f7e680c01cebac816c0ef6217aa5
> 100644
> --- a/Source/core/svg/SVGLangSpace.cpp
> +++ b/Source/core/svg/SVGLangSpace.cpp
> @@ -67,15 +67,13 @@ bool SVGLangSpace::isKnownAttribute(const QualifiedName&
> attrName)
>
>  void SVGLangSpace::addSupportedAttributes(HashSet<QualifiedName>&
> supportedAttributes)
>  {
> -    DEFINE_STATIC_LOCAL(AtomicString, xmlPrefix, ("xml",
> AtomicString::ConstructFromLiteral));
> -
>      QualifiedName langWithPrefix = XMLNames::langAttr;
> -    langWithPrefix.setPrefix(xmlPrefix);
> +    langWithPrefix.setPrefix(xmlAtom);
>      supportedAttributes.add(langWithPrefix);
>      supportedAttributes.add(XMLNames::langAttr);
>
>      QualifiedName spaceWithPrefix = XMLNames::spaceAttr;
> -    spaceWithPrefix.setPrefix(xmlPrefix);
> +    spaceWithPrefix.setPrefix(xmlAtom);
>      supportedAttributes.add(spaceWithPrefix);
>      supportedAttributes.add(XMLNames::spaceAttr);
>  }
> Index: Source/core/timing/Performance.cpp
> diff --git a/Source/core/timing/Performance.cpp
> b/Source/core/timing/Performance.cpp
> index
>
07a20310c3916a41411108d324c78d5f18b84e08..e441579b930df6dc43251b7f826effcfc1e855d6
> 100644
> --- a/Source/core/timing/Performance.cpp
> +++ b/Source/core/timing/Performance.cpp
> @@ -171,7 +171,7 @@ static bool passesTimingAllowCheck(const
> ResourceResponse& response, Document* r
>      if (timingAllowOriginString.isEmpty() ||
> equalIgnoringCase(timingAllowOriginString, "null"))
>          return false;
>
> -    if (timingAllowOriginString == "*")
> +    if (timingAllowOriginString == starAtom)
>          return true;
>
>      const String& securityOrigin =
> requestingDocument->securityOrigin()->toString();
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-06 18:35:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/108683002/1

[commit-bot: I haz the power, 2013-12-06 19:33:41]

Change committed as 163359